Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace backslashes with forward slashes in refs on Windows when splitting #1903

Merged
merged 6 commits into from
Feb 14, 2025

Conversation

tatomyr
Copy link
Contributor

@tatomyr tatomyr commented Feb 12, 2025

What/Why/How?

  • Replaced backslashes in file paths on Windows
  • Moved smoke preparation scripts to the corresponding folder

NB: When reviewing, you can ignore files in the __tests__/smoke/pre-split folder as they are simply example splits of museum.yaml and pets.yaml. The actual fix is here.

Reference

Fixes #638

Testing

Added a smoke test.

Screenshots (optional)

Check yourself

  • Code changed? - Tested with redoc/reference-docs/workflows (internal)
  • All new/updated code is covered with tests
  • New package installed? - Tested in different environments (browser/node)

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Copy link

changeset-bot bot commented Feb 12, 2025

🦋 Changeset detected

Latest commit: 95eb738

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@redocly/cli Patch
@redocly/openapi-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tatomyr tatomyr force-pushed the fix/split-produces-backslashes-on-win branch from 185c836 to 5104581 Compare February 12, 2025 14:53
Copy link
Contributor

github-actions bot commented Feb 12, 2025

Command Mean [ms] Min [ms] Max [ms] Relative
redocly lint packages/core/src/benchmark/benches/rebilly.yaml 954.6 ± 21.9 932.3 999.2 1.00
redocly-next lint packages/core/src/benchmark/benches/rebilly.yaml 961.0 ± 16.0 944.0 996.9 1.01 ± 0.03

Copy link
Contributor

github-actions bot commented Feb 12, 2025

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 78.54% 5062/6445
🟡 Branches 67.24% 2065/3071
🟡 Functions 73.2% 836/1142
🟡 Lines 78.82% 4775/6058

Test suite run success

839 tests passing in 121 suites.

Report generated by 🧪jest coverage report action from 95eb738

@tatomyr tatomyr force-pushed the fix/split-produces-backslashes-on-win branch 5 times, most recently from 4767b3d to f6caa34 Compare February 12, 2025 15:47
@tatomyr tatomyr force-pushed the fix/split-produces-backslashes-on-win branch 8 times, most recently from 00d1b81 to 0cc5b3c Compare February 13, 2025 10:28
@tatomyr tatomyr force-pushed the fix/split-produces-backslashes-on-win branch from 0cc5b3c to 3c4c158 Compare February 13, 2025 10:35
@tatomyr tatomyr marked this pull request as ready for review February 13, 2025 10:48
@tatomyr tatomyr requested review from a team as code owners February 13, 2025 10:48
@tatomyr tatomyr requested a review from Marshevskyy February 13, 2025 11:04
@tatomyr tatomyr force-pushed the fix/split-produces-backslashes-on-win branch from 0e13c10 to 317c372 Compare February 13, 2025 17:51
@tatomyr tatomyr force-pushed the fix/split-produces-backslashes-on-win branch from 317c372 to 95eb738 Compare February 13, 2025 17:59
@Marshevskyy Marshevskyy merged commit 79b6460 into main Feb 14, 2025
41 checks passed
@Marshevskyy Marshevskyy deleted the fix/split-produces-backslashes-on-win branch February 14, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

$refs are created with the backslashes on Windows
4 participants