-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: replace backslashes with forward slashes in refs on Windows when splitting #1903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 95eb738 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
185c836
to
5104581
Compare
|
Coverage report
Test suite run success839 tests passing in 121 suites. Report generated by 🧪jest coverage report action from 95eb738 |
4767b3d
to
f6caa34
Compare
00d1b81
to
0cc5b3c
Compare
0cc5b3c
to
3c4c158
Compare
JLekawa
reviewed
Feb 13, 2025
JLekawa
approved these changes
Feb 13, 2025
volodymyr-rutskyi
approved these changes
Feb 13, 2025
tatomyr
commented
Feb 13, 2025
0e13c10
to
317c372
Compare
317c372
to
95eb738
Compare
Marshevskyy
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why/How?
NB: When reviewing, you can ignore files in the
__tests__/smoke/pre-split
folder as they are simply example splits ofmuseum.yaml
andpets.yaml
. The actual fix is here.Reference
Fixes #638
Testing
Added a smoke test.
Screenshots (optional)
Check yourself
Security