Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build-docs failure with React 19 #1892

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

tatomyr
Copy link
Contributor

@tatomyr tatomyr commented Feb 7, 2025

What/Why/How?

Fixed the build-docs command failure when React 19 is installed in the project folder.

Reference

Resolves #1824 (hopefully 🤞)

Testing

Screenshots (optional)

Check yourself

  • Code changed? - Tested with redoc/reference-docs/workflows (internal)
  • All new/updated code is covered with tests
  • New package installed? - Tested in different environments (browser/node)

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

@tatomyr tatomyr requested a review from AlexVarchuk February 7, 2025 15:03
Copy link

changeset-bot bot commented Feb 7, 2025

🦋 Changeset detected

Latest commit: d4d326b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@redocly/cli Patch
@redocly/openapi-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 7, 2025

Command Mean [ms] Min [ms] Max [ms] Relative
redocly lint packages/core/src/benchmark/benches/rebilly.yaml 969.4 ± 18.6 953.5 1016.4 1.01 ± 0.03
redocly-next lint packages/core/src/benchmark/benches/rebilly.yaml 964.2 ± 20.7 938.0 1010.1 1.00

Copy link
Contributor

github-actions bot commented Feb 7, 2025

Coverage report

❌ An unexpected error occurred. For more details, check console

Error: The process '/opt/hostedtoolcache/node/20.18.2/x64/bin/npm' failed with exit code 1
St.
Category Percentage Covered / Total
🟡 Statements 78.6% 5053/6429
🟡 Branches 67.18% 2059/3065
🟡 Functions 73.16% 834/1140
🟡 Lines 78.88% 4767/6043

Test suite run failed

Failed tests: 1/843. Failed suites: 1/122.
  ● no-invalid-media-type-examples › should report invalid value when externalValue is also set

    thrown: "Exceeded timeout of 5000 ms for a test.
    Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

      605 |   });
      606 |
    > 607 |   it('should report invalid value when externalValue is also set', async () => {
          |   ^
      608 |     const document = parseYamlToDocument(
      609 |       outdent`
      610 |         openapi: 3.0.0

      at packages/core/src/rules/oas3/__tests__/no-invalid-media-type-examples.test.ts:607:3
      at Object.<anonymous> (packages/core/src/rules/oas3/__tests__/no-invalid-media-type-examples.test.ts:6:1)

Report generated by 🧪jest coverage report action from d4d326b

@tatomyr tatomyr force-pushed the fix/build-docs-with-redoc-react19 branch from 7e0d554 to c733fe4 Compare February 7, 2025 15:06
@tatomyr tatomyr force-pushed the fix/build-docs-with-redoc-react19 branch from c733fe4 to 71598de Compare February 7, 2025 15:25
@tatomyr tatomyr marked this pull request as ready for review February 7, 2025 15:34
@tatomyr tatomyr requested review from a team as code owners February 7, 2025 15:34
@Marshevskyy Marshevskyy merged commit f77f19b into main Feb 7, 2025
41 checks passed
@Marshevskyy Marshevskyy deleted the fix/build-docs-with-redoc-react19 branch February 7, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build-docs fails with React 19
4 participants