Skip to content

feat: use translate=no attribute in code sensitive renderings #2697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: use translate=no attribute in code sensitive renderings #2697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/ApiInfo/ApiInfo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ export class ApiInfo extends React.Component<ApiInfoProps> {
)) ||
null;

const version = (info.version && <span>({info.version})</span>) || null;
const version = (info.version && <span translate="no">({info.version})</span>) || null;

return (
<Section>
Expand Down
6 changes: 3 additions & 3 deletions src/components/Endpoint/Endpoint.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,10 @@ export class Endpoint extends React.Component<EndpointProps, EndpointState> {
{options => (
<OperationEndpointWrap>
<EndpointInfo onClick={this.toggle} $expanded={expanded} $inverted={inverted}>
<HttpVerb type={operation.httpVerb} $compact={this.props.compact}>
<HttpVerb type={operation.httpVerb} $compact={this.props.compact} translate="no">
{operation.httpVerb}
</HttpVerb>
<ServerRelativeURL>{operation.path}</ServerRelativeURL>
<ServerRelativeURL translate="no">{operation.path}</ServerRelativeURL>
<ShelfIcon
float={'right'}
color={inverted ? 'black' : 'white'}
Expand All @@ -73,7 +73,7 @@ export class Endpoint extends React.Component<EndpointProps, EndpointState> {
<Markdown source={server.description || ''} compact={true} />
<SelectOnClick>
<ServerUrl>
<span>
<span translate="no">
{hideHostname || options.hideHostname
? basePath === '/'
? ''
Expand Down
12 changes: 6 additions & 6 deletions src/components/Fields/Field.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,13 +80,13 @@ export class Field extends React.Component<FieldProps> {
onKeyPress={this.handleKeyPress}
aria-label={`expand ${name}`}
>
{!hidePropertiesPrefix &&
fieldParentsName.map(
name => name + '.\u200B', // zero-width space, a special character is used for correct line breaking
)}
<span className="property-name">{name}</span>
<ShelfIcon direction={expanded ? 'down' : 'right'} />
</button>
{!hidePropertiesPrefix &&
fieldParentsName.map(
name => name + '.\u200B', // zero-width space, a special character is used for correct line breaking
)}
<span className="property-name" translate="no">{name}</span>
{labels}
</ClickablePropertyNameCell>
) : (
Expand All @@ -96,7 +96,7 @@ export class Field extends React.Component<FieldProps> {
fieldParentsName.map(
name => name + '.\u200B', // zero-width space, a special character is used for correct line breaking
)}
<span className="property-name">{name}</span>
<span className="property-name" translate="no">{name}</span>
{labels}
</PropertyNameCell>
);
Expand Down
2 changes: 1 addition & 1 deletion src/components/Fields/FieldConstraints.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export class ConstraintsView extends React.PureComponent<ConstraintsViewProps> {
<span>
{' '}
{this.props.constraints.map(constraint => (
<ConstraintItem key={constraint}> {constraint} </ConstraintItem>
<ConstraintItem key={constraint} translate="no"> {constraint} </ConstraintItem>
))}
</span>
);
Expand Down
2 changes: 1 addition & 1 deletion src/components/SecuritySchemes/SecuritySchemes.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export class SecurityDefs extends React.PureComponent<SecurityDefsProps> {
<SecurityDetailsStyle>
<SecurityRow>
<b>Security Scheme Type: </b>
<span>{AUTH_TYPES[scheme.type] || scheme.type}</span>
<span translate="no">{AUTH_TYPES[scheme.type] || scheme.type}</span>
</SecurityRow>
<SecurityDetails scheme={scheme} />
</SecurityDetailsStyle>
Expand Down
6 changes: 3 additions & 3 deletions src/utils/jsonToHtml.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,11 @@ function stringifyStringLiteral(str: string) {
}

function decorateWithSpan(value, className) {
return '<span class="' + className + '">' + htmlEncode(value) + '</span>';
return '<span class="' + className + '" translate="no">' + htmlEncode(value) + '</span>';
}

function punctuation(val) {
return '<span class="token punctuation">' + val + '</span>';
return '<span class="token punctuation" translate="no">' + val + '</span>';
}

function valueToHTML(value, maxExpandLevel: number) {
Expand Down Expand Up @@ -106,7 +106,7 @@ function objectToHTML(json, maxExpandLevel: number) {
const key = keys[i];
hasContents = true;
output += '<li><div class="hoverable ' + collapsed + '">';
output += '<span class="property token string">"' + htmlEncode(key) + '"</span>: ';
output += '<span class="property token string" translate="no">"' + htmlEncode(key) + '"</span>: ';
output += valueToHTML(json[key], maxExpandLevel);
if (i < length - 1) {
output += punctuation(',');
Expand Down