Skip to content

OPCR-20: AWS PrivateLink #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Sep 18, 2025
Merged

OPCR-20: AWS PrivateLink #226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
5efa607
chore(deps): bump github.com/stretchr/testify from 1.10.0 to 1.11.1
dependabot[bot] Aug 28, 2025
1ceb4f5
feat: adding privatelink service and model
burythehammer Sep 3, 2025
2e5fa32
feat: updating privatelink fields
burythehammer Sep 4, 2025
eb8e72e
feat: updating model for privatelink and corresponding test
burythehammer Sep 4, 2025
d91debd
chore: updating DELETE function to support a request body
burythehammer Sep 11, 2025
16893c1
feat: add create principal endpoint
burythehammer Sep 16, 2025
2ca4267
feat: adding active active endpoints
burythehammer Sep 16, 2025
3884416
feat: adding new statuses for private link principals
burythehammer Sep 17, 2025
8e04bbc
test: fixing tests
burythehammer Sep 17, 2025
59ac975
feat: adding get privatelink endpoint script and other fixes
burythehammer Sep 17, 2025
ddcfe64
feat: adding endpoints for script get endpoints
burythehammer Sep 17, 2025
58003be
chore: rename subscriptionid
burythehammer Sep 18, 2025
c6edcbe
fix: missing regionId in endpoint
burythehammer Sep 18, 2025
0dfbb1c
docs: changelog.md
burythehammer Sep 18, 2025
6aba8b6
chore: update error message
burythehammer Sep 18, 2025
cc81b95
test: adding active active privatelink test
burythehammer Sep 18, 2025
55f9e67
test: removing commented out test
burythehammer Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,15 @@ All notable changes to this project will be documented in this file.
See updating [Changelog example here](https://keepachangelog.com/en/1.0.0/).


## 0.36.0

# Added:
* Adding model and service for new PrivateLink endpoints

# Changed:
* Modified `delete` in API client so that it takes a `requestBody` parameter.
* Updating Testify to v1.11.1

## 0.35.0

### Added:
Expand Down
8 changes: 5 additions & 3 deletions client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,10 @@ import (
"regexp"
"strings"

"github.com/RedisLabs/rediscloud-go-api/internal"
"github.com/RedisLabs/rediscloud-go-api/service/access_control_lists/redis_rules"
"github.com/RedisLabs/rediscloud-go-api/service/access_control_lists/roles"
"github.com/RedisLabs/rediscloud-go-api/service/access_control_lists/users"
"github.com/RedisLabs/rediscloud-go-api/service/psc"

"github.com/RedisLabs/rediscloud-go-api/internal"
"github.com/RedisLabs/rediscloud-go-api/service/account"
"github.com/RedisLabs/rediscloud-go-api/service/cloud_accounts"
"github.com/RedisLabs/rediscloud-go-api/service/databases"
Expand All @@ -27,6 +25,8 @@ import (
"github.com/RedisLabs/rediscloud-go-api/service/latest_imports"
"github.com/RedisLabs/rediscloud-go-api/service/maintenance"
"github.com/RedisLabs/rediscloud-go-api/service/pricing"
"github.com/RedisLabs/rediscloud-go-api/service/privatelink"
"github.com/RedisLabs/rediscloud-go-api/service/psc"
"github.com/RedisLabs/rediscloud-go-api/service/regions"
"github.com/RedisLabs/rediscloud-go-api/service/subscriptions"
"github.com/RedisLabs/rediscloud-go-api/service/tags"
Expand All @@ -45,6 +45,7 @@ type Client struct {
Pricing *pricing.API
TransitGatewayAttachments *attachments.API
PrivateServiceConnect *psc.API
PrivateLink *privatelink.API
Tags *tags.API
// fixed
FixedPlans *plans.API
Expand Down Expand Up @@ -94,6 +95,7 @@ func NewClient(configs ...Option) (*Client, error) {
Pricing: pricing.NewAPI(client),
TransitGatewayAttachments: attachments.NewAPI(client, t, config.logger),
PrivateServiceConnect: psc.NewAPI(client, t, config.logger),
PrivateLink: privatelink.NewAPI(client, t, config.logger),
Tags: tags.NewAPI(client),
// fixed
FixedPlans: plans.NewAPI(client, config.logger),
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ go 1.23.0

require (
github.com/avast/retry-go/v4 v4.6.0
github.com/stretchr/testify v1.10.0
github.com/stretchr/testify v1.11.1
golang.org/x/tools v0.36.0
)

Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZb
github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
github.com/stretchr/objx v0.5.2 h1:xuMeJ0Sdp5ZMRXx/aWO6RZxdr3beISkG5/G/aIRr3pY=
github.com/stretchr/objx v0.5.2/go.mod h1:FRsXN1f5AsAjCGJKqEizvkpNtU+EGNCLh3NxZ/8L+MA=
github.com/stretchr/testify v1.10.0 h1:Xv5erBjTwe/5IxqUQTdXv5kgmIvbHo3QQyRwhJsOfJA=
github.com/stretchr/testify v1.10.0/go.mod h1:r2ic/lqez/lEtzL7wO/rwa5dbSLXVDPFyf8C91i36aY=
github.com/stretchr/testify v1.11.1 h1:7s2iGBzp5EwR7/aIZr8ao5+dra3wiQyKjjFuvgVKu7U=
github.com/stretchr/testify v1.11.1/go.mod h1:wZwfW3scLgRK+23gO65QZefKpKQRnfz6sD981Nm4B6U=
golang.org/x/mod v0.27.0 h1:kb+q2PyFnEADO2IEF935ehFUXlWiNjJWtRNgBLSfbxQ=
golang.org/x/mod v0.27.0/go.mod h1:rWI627Fq0DEoudcK+MBkNkCe0EetEaDSwJJkCcjpazc=
golang.org/x/sync v0.16.0 h1:ycBJEhp9p4vXvUZNszeOq0kGTPghopOL8q0fq3vstxw=
Expand Down
4 changes: 2 additions & 2 deletions internal/http_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,8 @@ func (c *HttpClient) Post(ctx context.Context, name, path string, requestBody in
return c.connectionWithRetries(ctx, http.MethodPost, name, path, nil, requestBody, responseBody)
}

func (c *HttpClient) Delete(ctx context.Context, name, path string, responseBody interface{}) error {
return c.connectionWithRetries(ctx, http.MethodDelete, name, path, nil, nil, responseBody)
func (c *HttpClient) Delete(ctx context.Context, name, path string, requestBody interface{}, responseBody interface{}) error {
return c.connectionWithRetries(ctx, http.MethodDelete, name, path, nil, requestBody, responseBody)
}

func (c *HttpClient) DeleteWithQuery(ctx context.Context, name, path string, requestBody interface{}, responseBody interface{}) error {
Expand Down
Loading
Loading