Fixing retrieving non-ascii string with JSON.GET, added no_escape flag #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks very much |
|
hello, is there a plan for this is merged? thanks! |
itamarhaber
approved these changes
Sep 1, 2019
|
Thanks @bentsku - this looks great - merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to solve the issue which comes from ReJSON itself as talked about in #19.
This pull request adds the
no_escapeboolean flag to the JSON.GET command, to retrieve non-ascii characters. This flag has been added as a fix in ReJSON and has been discussed in the issue RedisJSON/RedisJSON#98It should be covered by the new tests, I didn't generate the new API.md file as I don't use python2.