feat: added show_description to listing attachment #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaraBianchi
reviewed
Apr 2, 2025
| @@ -64,7 +66,7 @@ const AttachmentCardTemplate = ({ | |||
| : item?.['@id'] + '/@@download/file', | |||
| }; | |||
| } | |||
|
|
|||
| const listingText = <ListingText item={item} />; | |||
There was a problem hiding this comment.
Lo sistemerei a questo punto qui:
const listingText = show_description ? (<ListingText item={item} />) : null;
SaraBianchi
reviewed
Apr 2, 2025
Comment on lines
+98
to
+100
| {show_description && listingText && ( | ||
| <div className="bando-description">{listingText}</div> | ||
| )} |
There was a problem hiding this comment.
{listingText && (<div className="bando-description">{listingText}</div>)
SaraBianchi
reviewed
Apr 2, 2025
| @@ -26,6 +27,7 @@ const AttachmentCardTemplate = ({ | |||
| linkTitle, | |||
| linkHref, | |||
| show_pdf_preview, | |||
| show_description, | |||
There was a problem hiding this comment.
show_description = false,
questo ti consente di dire che se non c'è settato alcun valore ancora è inizializzato a false
SaraBianchi
reviewed
Apr 2, 2025
Comment on lines
+36
to
+38
| show_description: { | ||
| default: false, | ||
| }, |
There was a problem hiding this comment.
credo che tu questo lo possa togliere perchè 'show_description' è una prop già note, infatti non vedo ne label ne description settate qui, prova a rimuoverlo e dimmi se lo vedi lo stesso
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.