Add Expandable section #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55 +/- ##
=======================================
Coverage 99.82% 99.83%
=======================================
Files 43 44 +1
Lines 1706 1766 +60
=======================================
+ Hits 1703 1763 +60
Misses 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jrusz
force-pushed
the
expandable-section
branch
from
cec1262 to
c68ce3b
Compare
|
Hi @digitronik can you review please? The way I'm using in iqe-image-builder can be seen here https://gitlab.cee.redhat.com/insights-qe/iqe-image-builder-plugin/-/merge_requests/123/diffs?commit_id=9cd1f31845166b173bb06d86afc4fb22fffc3271 |
digitronik
requested changes
Mar 15, 2024
jrusz
force-pushed
the
expandable-section
branch
from
c68ce3b to
33149c4
Compare
digitronik
approved these changes
Mar 15, 2024
jrusz
force-pushed
the
expandable-section
branch
from
33149c4 to
b2a38a2
Compare
|
LGTM 👍 Thanks @jrusz for this work. The failures are not related to this. I will work on fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding this mainly because of the
child_widget_accessfunctionality. The widget is fairly simple, I was heavily inspired by thetabswidget.Adding just a basic test as all the other sections work the same on the page and the text is visible anyway even without expanding. I have a better use case in iqe-image-builder plugin where I need to expand the section to access a button which is actually not clickable before. It works there for me as expected and even watching the test here it does expand the section before trying to read it.
I am not adding a
section_nameproperty for it as it can change based on whether it's expanded or not so I don't think it's very useful unlike thetab_namein thetabswidget...