Make pagination backward compatible #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LightOfHeaven1994
force-pushed
the
make-pagination-backward-compatible
branch
2 times, most recently
from
f8accdc to
b2ee0b2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #50 +/- ##
=======================================
Coverage 99.82% 99.82%
=======================================
Files 43 43
Lines 1677 1677
=======================================
Hits 1674 1674
Misses 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
LightOfHeaven1994
force-pushed
the
make-pagination-backward-compatible
branch
from
b2ee0b2 to
4d67bc9
Compare
|
ahhhh I forgot this :) was busy with migration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found out that some compliance tests are failing due to PF5 usage (we are not migrated to PF5 yet but I have already started using it). With making locators more generic tests are green (PF5 should work as normal)