Do not comment out all kickstart lines in README #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having all lines in kickstart example as comments is not great for people to copy & paste because they then have to change all the lines.
|
Hey Jiri, thanks for the issue. I did that because I figured users would copy/paste and there are some fields there that must be customized, like the auth/ssh lines (which in your PR would yield a system where no one knows the password). |
|
I wonder if this is more confusing or helpful. But I'll leave that decision on you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having all lines in kickstart example as comments is not great for people to copy & paste because they then have to change all the lines.