Skip to content

feat(ci): add npm-publish environment for trusted publisher #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
karelhala merged 1 commit into from
Jul 7, 2026
Merged

feat(ci): add npm-publish environment for trusted publisher #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ on:
push:
branches:
- master
workflow_dispatch:

permissions:
contents: read
Expand All @@ -15,6 +14,7 @@ jobs:
name: Release Packages
# Only run on push to master branch (never on workflow_dispatch, etc.)
if: github.event_name == 'push' && github.ref == 'refs/heads/master'

@coderabbitai coderabbitai Bot Jun 11, 2026 •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Redundant if condition contradicts PR description.

The PR description states "Removes the if guard since the only remaining trigger is push to master", but the if condition is still present on line 16. Since the workflow now only triggers on push to master (lines 4-6), this condition always evaluates to true when the job runs and should be removed.

♻️ Proposed fix 
     name: Release Packages
-    # Only run on push to master branch (never on workflow_dispatch, etc.)
-    if: github.event_name == 'push' && github.ref == 'refs/heads/master'
     environment: npm-publish
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/release.yml at line 16, Remove the redundant job-level
condition "if: github.event_name == 'push' && github.ref == 'refs/heads/master'"
from the release workflow (it duplicates the top-level trigger); open
.github/workflows/release.yml, locate the job that contains the if: line and
delete that entire conditional so the job relies solely on the workflow's
push-to-master trigger.

@justinorringer justinorringer Jun 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is redundant code. If Karel doesn't remove it by next week, there shouldnt be a problem with merging the other changes.

@coderabbitai coderabbitai Bot Jun 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justinorringer Thanks for the note! Would you like me to open a follow-up issue to track the removal of that redundant if condition, so it doesn't get lost?

environment: npm-publish
permissions:
contents: write # Needed for creating tags and GitHub releases
id-token: write # Needed for OIDC token generation (npm trusted publishing)
Expand Down
Loading