chore(npm): npmignore for mcps - #59
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (2)
Summary by CodeRabbit
WalkthroughThis PR establishes consistent npm package publishing controls by adding documentation and governance for Changesnpm package publishing controls
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
karelhala
left a comment
There was a problem hiding this comment.
Do we want to have multiple .npmignore files or just one with all configs?
Multiple seems like the standard way to go [1]. Claude really preferred removing them entirely and only relying on the files fields though, but that would require adding the package.json to the CODEOWNERS rules (and more labor for dependency changes). |
karelhala
left a comment
There was a problem hiding this comment.
Looking good, just minor adjustment and we are golden.
Simplified JavaScript file ignore patterns in all three MCP packages: - Changed from `/*.js` + `packages/*/**/*.js` + `!packages/*/dist/**/*.js` to simpler `**/*.js` + `!dist/**/*.js` - Removed duplicate `/*.js` line from Development files section - Kept `.vscode/` ignore (already present) This addresses PR feedback to use more standard glob patterns. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
Great! updated and ran builds locally, looks like the dist dir content is correct. |
Description
Adds 3 npm ignore files. Looks like the jira-mcp was killed a while ago (so not included)
RHCLOUD-48283
Blast radius
Rollback plan
Checklist
latestAI disclosure