fix(Shield): fix Shield spacing without QuestionIcon #2171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AsToNlele
reviewed
Feb 19, 2025
|
This is not intended. Definitely needs to be fixed. Not sure how it's happening. |
johnsonm325
requested changes
Feb 19, 2025
| </Icon> | ||
| ) | ||
| ) : ( | ||
| <Icon> |
There was a problem hiding this comment.
Add the size in here as well.
<Icon size={size}>
xmicha82
force-pushed
the
shield-spacing
branch
from
3f418e8 to
d04296a
Compare
johnsonm325
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusted Shield to not render Icon container when question icon is disabled