Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config-utils): add navigation bundle interceptor #2134

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions navnotes.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
# Nav notes updates

## Current attributes

### appId

For some reason nav items in expandable item require `appId` to show. This should not be required a it needs to b fixed in chrome: https://github.com/RedHatInsights/insights-chrome/blob/master/src/components/Navigation/ChromeNavExpandable.tsx#L7

### id

Id should be mandatory attribute of any non segment nav item


## Missing FEO nav attributes

### bundleSegmentRef

Required to match nav item to bundle segment from frontend crd.

Nav items should inherit this from the bundle segment they come from.

Should be needed only by the first level.

### segmentRef

Same as `bundleSegmentRef`, but for global segments.

### frontendRef

Required to match nav item in bundle to current app
9 changes: 8 additions & 1 deletion packages/config-utils/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,13 @@
"options": {
"command": "git push --tags"
}
}
},
"test:unit": {
"executor": "@nx/jest:jest",
"outputs": ["{workspaceRoot}/coverage/{projectRoot}"],
"options": {
"jestConfig": "packages/config-utils/jest.config.ts"
}
},
}
}
Loading
Loading