feat(devtool): Ability to pass custom devtool option to config #2063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hyperkid123
reviewed
Sep 16, 2024
adonispuente
force-pushed
the
sentry
branch
from
f0d27ca to
1380eec
Compare
Hyperkid123
reviewed
Sep 17, 2024
| @@ -117,7 +119,7 @@ export const createConfig = ({ | |||
| const devServerPort = typeof port === 'number' ? port : useProxy || standalone ? 1337 : 8002; | |||
| return { | |||
| mode: mode || (isProd ? 'production' : 'development'), | |||
| devtool: false, | |||
| devtool: devtool || false, | |||
There was a problem hiding this comment.
The default value is set in the argument now you can simply use devtool: devtool, or just devtool,.
There was a problem hiding this comment.
I got a bit too caught up in the meeting, thank you!
adonispuente
force-pushed
the
sentry
branch
from
1380eec to
478fe59
Compare
Hyperkid123
approved these changes
Sep 18, 2024
|
:soon::shipit::octocat: |
|
🌱 🌸 🌷 🌻 🌟 New version of package has been released 🌟 🌻 🌷 🌸 🌱 The release is available on: :package:@redhat-cloud-services/frontend-components-config/v/6.2.9📦 :boom:This feature is brought to you by probot🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because apps now use fec as the default config, I want to add the ability to pass in a devtool option. With this we can pass in 'hidden-source-map' for apps that will use sentry. Eventually I want this to just be the default value but I want to use advisor as a test application first.
Now that more of the sentry efforts are unblocked this can move along much faster.
RedHatInsights/insights-advisor-frontend#1268 related PR