Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid imports and eager loading of core singleton packages. #2043

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

Hyperkid123
Copy link
Contributor

These changes ensure that only one instance of core singleton packages is ever loaded to the shell application.

@Hyperkid123 Hyperkid123 added release Once merged it will trigger bugfix release tech debt labels Aug 7, 2024
@Hyperkid123 Hyperkid123 requested a review from a team August 7, 2024 07:52
@Hyperkid123 Hyperkid123 marked this pull request as ready for review August 7, 2024 07:52
@Hyperkid123 Hyperkid123 merged commit b324793 into RedHatInsights:master Aug 7, 2024
3 checks passed
@Hyperkid123 Hyperkid123 deleted the singleton-imports branch August 7, 2024 08:07
@nacho-bot
Copy link
Collaborator

                      :soon::shipit::octocat:
     :bug:Shipit Squirrel has this release bugfix surrounded, be ready for a new version:beetle:

@nacho-bot
Copy link
Collaborator

     🌱 🌸 🌷 🌻 🌟 New version of package has been released 🌟 🌻 🌷 🌸 🌱

                The release is available on:

       :package:@redhat-cloud-services/frontend-components-config-utilities/v/3.2.1📦

             :boom:This feature is brought to you by probot🚀

@nacho-bot nacho-bot added the released Pr has been released label Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Once merged it will trigger bugfix release released Pr has been released tech debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants