Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TagModal empty state and skeleton loader #1998

Merged
merged 1 commit into from
May 23, 2024
Merged

Fix TagModal empty state and skeleton loader #1998

merged 1 commit into from
May 23, 2024

Conversation

leSamo
Copy link
Member

@leSamo leSamo commented Apr 24, 2024

  • add missing spaces to empty state title
  • change skeleton table variant to compact so that it resembles the loaded table more
  • use the PF skeleton table

@leSamo leSamo changed the title Fix TagColumn empty state and skeleton loader Fix TagModal empty state and skeleton loader May 13, 2024
@mkholjuraev mkholjuraev requested a review from Hyperkid123 May 22, 2024 11:26
@Hyperkid123 Hyperkid123 added the release Once merged it will trigger bugfix release label May 23, 2024
@Hyperkid123 Hyperkid123 merged commit 29b3912 into RedHatInsights:master May 23, 2024
2 checks passed
@nacho-bot
Copy link
Collaborator

                      :soon::shipit::octocat:
     :bug:Shipit Squirrel has this release bugfix surrounded, be ready for a new version:beetle:

@nacho-bot
Copy link
Collaborator

     🌱 🌸 🌷 🌻 🌟 New version of package has been released 🌟 🌻 🌷 🌸 🌱

                The release is available on:

         :package:@redhat-cloud-services/frontend-components/v/4.2.10📦

             :boom:This feature is brought to you by probot🚀

@nacho-bot nacho-bot added the released Pr has been released label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hyperkid123 Hyperkid123 Hyperkid123 approved these changes

Assignees
No one assigned
Labels
release Once merged it will trigger bugfix release released Pr has been released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leSamo @nacho-bot @Hyperkid123