fix(RHINENG-9046): report details remove Usechrome hook #1992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fewwy
force-pushed
the
reportdetails-remove-usechrome-hook
branch
from
0ce5ed9 to
176039a
Compare
Fewwy
force-pushed
the
reportdetails-remove-usechrome-hook
branch
from
8c2c503 to
9878370
Compare
gkarat
approved these changes
Mar 28, 2024
| @@ -65,6 +65,7 @@ describe('report details: kba loaded', () => { | |||
| }); | |||
|
|
|||
| it('renders a loaded kba link', () => { | |||
| cy.mount(<ReportDetails {...{ ...props, kbaLoading: true, isProd: true }} />); | |||
There was a problem hiding this comment.
You are calling cy.mount twice (one in beforeEach, and one in it). It's not healthy for the test, and we better keep only one mount command. Can we just add this prop in cy.mount in beforeEach above?
Fewwy
added
release
Hyperkid123
approved these changes
Apr 2, 2024
|
:soon::shipit::octocat: |
|
🌱 🌸 🌷 🌻 🌟 New version of package has been released 🌟 🌻 🌷 🌸 🌱 The release is available on: :package:@redhat-cloud-services/frontend-components-advisor-components/v/1.0.19📦 :boom:This feature is brought to you by probot🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/RHINENG-9046