Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): Make rbac-client proper dependency #1973

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

bastilian
Copy link
Member

Both the RBAC and the RBACHook[0] modules import from @redhat-cloud-services/rbac-client.

Using the hook without having the rbac-client already as a dependency or installed in a project will cause a module not found error.

[0] https://github.com/RedHatInsights/frontend-components/blob/master/packages/utils/src/RBACHook/RBACHook.ts#L3

@bastilian bastilian requested a review from a team February 22, 2024 12:36
Copy link
Contributor

@Fewwy Fewwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hyperkid123 Hyperkid123 added the release Once merged it will trigger bugfix release label Feb 22, 2024
@Hyperkid123 Hyperkid123 merged commit d03da23 into RedHatInsights:master Feb 22, 2024
2 checks passed
@nacho-bot
Copy link
Collaborator

                      :soon::shipit::octocat:
     :bug:Shipit Squirrel has this release bugfix surrounded, be ready for a new version:beetle:

@nacho-bot
Copy link
Collaborator

     🌱 🌸 🌷 🌻 🌟 New version of package has been released 🌟 🌻 🌷 🌸 🌱

                The release is available on:

        :package:@redhat-cloud-services/frontend-components-utilities/v/4.0.6📦

             :boom:This feature is brought to you by probot🚀

@nacho-bot nacho-bot added the released Pr has been released label Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Once merged it will trigger bugfix release released Pr has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants