Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove setState call from ErrorBoundary render function. #1901

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Remove setState call from ErrorBoundary render function. #1901

merged 1 commit into from
Aug 30, 2023

Conversation

Hyperkid123
Copy link
Contributor

@Hyperkid123 Hyperkid123 commented Aug 29, 2023 •
edited
Loading

Jira: https://issues.redhat.com/browse/RHCLOUD-27770

TODO after PR is merged:

  • add to the v4 release
  • bump notifications FEC dependency

@Hyperkid123 Hyperkid123 requested a review from a team August 29, 2023 08:01
@Hyperkid123
Copy link
Contributor Author

Do not add a release label! It will override current v4. Until the PF5 branch becomes master, we have to make the release manually.

@fhlavac fhlavac mentioned this pull request Aug 29, 2023
Merged
@Hyperkid123 Hyperkid123 force-pushed the fix-error-boundary-state-call branch from 24913d2 to 4b38231 Compare August 30, 2023 08:27
@fhlavac fhlavac mentioned this pull request Aug 30, 2023
Merged
@Hyperkid123 Hyperkid123 added the release Once merged it will trigger bugfix release label Aug 30, 2023
@Hyperkid123 Hyperkid123 merged commit dfd0f57 into RedHatInsights:master Aug 30, 2023
2 checks passed
@Hyperkid123 Hyperkid123 deleted the fix-error-boundary-state-call branch August 30, 2023 09:43
@nacho-bot
Copy link
Collaborator

                      :soon::shipit::octocat:
     :bug:Shipit Squirrel has this release bugfix surrounded, be ready for a new version:beetle:

@nacho-bot
Copy link
Collaborator

     🌱 🌸 🌷 🌻 🌟 New version of package has been released 🌟 🌻 🌷 🌸 🌱

                The release is available on:

         :package:@redhat-cloud-services/frontend-components/v/4.0.4📦

             :boom:This feature is brought to you by probot🚀

@nacho-bot nacho-bot added the released Pr has been released label Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karelhala karelhala karelhala approved these changes

Assignees
No one assigned
Labels
release Once merged it will trigger bugfix release released Pr has been released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hyperkid123 @nacho-bot @karelhala