Reviewing Changes - #2
Conversation
…dmin-access-to-see-argoapps Adding kustomize configuration to give access to argo apps in the arg…
…oud/kustomization.yaml
… updates in a controlled manner in order to coordinate with argo and/or other things that may be using the gpu operator once it tries to update.
strangiato
left a comment
strangiato
left a comment
There was a problem hiding this comment.
Added a few thoughts/feedback notes
| @@ -0,0 +1 @@ | |||
|
|
|||
There was a problem hiding this comment.
This was probably an accidental commit
| @@ -9,3 +9,11 @@ patches: | |||
| kind: Subscription | |||
There was a problem hiding this comment.
Instead of using the eus-2.16 overlay, I would recommend creating a seperate overlay called something like ibmcloud-stable or something like that.
That way you can use that ibmcloud overlay for this cluster, but other clusters can still leverage the other overlays in the future.
| name: openshift-pipelines-operator | ||
| namespace: openshift-operators | ||
| version: v1alpha1 | ||
| - patch: |- |
There was a problem hiding this comment.
This is mostly personal preference, but I like to keep the target above the patch/path.
I feel like it makes it easier to read.
| metadata: | ||
| annotations: | ||
| argocd.argoproj.io/sync-options: SkipDryRunOnMissingResource=true | ||
| argocd.argoproj.io/tracking-id: openshift-ai-operator:datasciencecluster.opendatahub.io/DataScienceCluster:redhat-ods-applications/default-dsc |
There was a problem hiding this comment.
Don't commit the tracking-id to git.
This is what Argo applies to follow what items it has deployed/manages.
| - patch: |- | ||
| - op: replace | ||
| path: "/metadata/name" | ||
| value: openshift-serverless-bh62z |
There was a problem hiding this comment.
Does this operatorgroup really have to be openshift-serverless-bh62z or are you just capturing the name for the operatorgroup that was created automatically?
I know that you guys mentioned IBMCloud was doing some weird enforcement on operator group names...
…ot relevant to customer engagement.
…out version updates.
3 participants
What does this PR do?
[Provide a short summary of what this PR does and why. Link to relevant issues if applicable.]
Checklist
Test Plan
[Describe the tests you ran to verify your changes with result summaries. Provide clear instructions so the plan can be easily re-executed.]