Skip to content

Check expiration of token #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Check expiration of token #218

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c08524
Check expiration of token
paulw11 Apr 6, 2020
3d2dd41
Update rest_framework_social_oauth2/oauth2_grants.py
paulw11 Apr 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions rest_framework_social_oauth2/oauth2_grants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import logging
import time

try:
from django.urls import reverse
Expand Down Expand Up @@ -90,6 +91,11 @@ def validate_token_request(self, request):

try:
user = backend.do_auth(access_token=request.token)
user_data = backend.user_data(access_token=request.token)
exp = user_data['exp']
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the value exp holds?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exp is the expiration date of the token

if not exp and exp <= datetime.now():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The not operator having higher precedence makes this always evaluate to False whenever exp evaluates to True. Can you please explain the desired operation here?

raise errors.InvalidTokenError('Token has expired', request=request)

except requests.HTTPError as e:
raise errors.InvalidRequestError(
description="Backend responded with HTTP{0}: {1}.".format(e.response.status_code,
Expand Down