-
Notifications
You must be signed in to change notification settings - Fork 37
Delete and retry tasks through Django Admin #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
mgax
wants to merge
3
commits into
RealOrangeOne:master
Choose a base branch
from
mgax:feature/admin-delete-and-retry
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,7 +10,7 @@ | |
from django.utils import timezone | ||
from django.utils.module_loading import import_string | ||
from django.utils.translation import gettext_lazy as _ | ||
from typing_extensions import ParamSpec | ||
from typing_extensions import ParamSpec, Self | ||
|
||
from django_tasks.task import ( | ||
DEFAULT_PRIORITY, | ||
|
@@ -167,6 +167,7 @@ def task_result(self) -> "TaskResult[T]": | |
|
||
object.__setattr__(task_result, "_exception_class", exception_class) | ||
object.__setattr__(task_result, "_traceback", self.traceback or None) | ||
object.__setattr__(task_result, "_return_value", self.return_value) | ||
|
||
return task_result | ||
|
||
|
@@ -226,3 +227,13 @@ def set_failed(self, exc: BaseException) -> None: | |
"traceback", | ||
] | ||
) | ||
|
||
def duplicate(self) -> Self: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Suggestion: This API feels like one better suited for the |
||
return type(self)( | ||
args_kwargs=self.args_kwargs, | ||
priority=self.priority, | ||
task_path=self.task_path, | ||
queue_name=self.queue_name, | ||
backend_name=self.backend_name, | ||
run_after=self.run_after, | ||
) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I rebased my changes, I noticed that this assertion was failing:
django-tasks/tests/tests/test_database_backend.py
Line 979 in dfb443e
I'm pretty sure this used to work, and it looks like the database backend is not fetching return values. Did I find a bug? I'm happy to write a specific test for checking that
return_value
is set on the task result.