Fix CI #48
Open
Fix CI #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CI build failure was caused by the deprecation of v3 artifact actions, which includes download-artifact@v3 and checkout@v3. See https://github.com/orgs/community/discussions/142581 for details. This fixes the versions of the GitHub actions so that the CI can pass. The seanmiddleditch/gha-setup-ninja action has been explicitly set to use @v6 version, since it's better for the thing to work than to break randomly. Well it's an archived repo, so like what's the difference anyway. Signed-off-by: Sunagatov Denis <[email protected]>
|
Just found out the CI doesn't actually do anything. Seems like the release is broken because the build.lua expects either |
flysand7
force-pushed
the
ci-fix
branch
3 times, most recently
from
828acbf to
b47583a
Compare
|
Ideally I'd move the release checks to their own CI file so that they don't get marked as skipped but I think this is good enough for now |
Since the build.lua script now requires an architecture as the input we need to be providing that in the CI script, which isn't. This builds the TB and Cuik compilers with both x64 and a64 support (because for now it is simpler than making a separate build per-architecture). This also fixes the CI build script, as earlier the artifacts would not be produced without architecture flag and the script would finish with warnings and no artifacts. Signed-off-by: Sunagatov Denis <[email protected]>
Linux builds were executing in PRs just fine, but windows only on the master branch. This makes builds consistent, so that windows builds also happen in PRs. Signed-off-by: Sunagatov Denis <[email protected]>
The build.lua script runs the DSL compilation under the hood, which requires string.buffer. As far as I understand this is a feature of luajit rather than lua, so the script was failing when running with lua. Signed-off-by: Sunagatov Denis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CI build failure was caused by the deprecation of v3 artifact actions, which includes download-artifact@v3 and checkout@v3. See https://github.com/orgs/community/discussions/142581 for details.
This fixes the versions of the GitHub actions so that the CI can pass. The seanmiddleditch/gha-setup-ninja action has been explicitly set to use @v6 version, since it's better for the thing to work than to break randomly. Well it's an archived repo, so like what's the difference anyway.