Skip to content

Conversation

@MayankBansal12
Copy link
Member

@MayankBansal12 MayankBansal12 commented Jan 1, 2026

Date: 01-01-2026

Developer Name: @MayankBansal12


Issue Ticket Number:-

Description:

  • Removes dev flag from new-signup
  • Replaces signupDev to dev for new fields like role in new signup
  • Updates tests for new signup route and controller

Is Under Feature Flag

  • Yes
  • No

Database changes

  • Yes
  • No

Breaking changes (If your feature is breaking/missing something please mention pending tickets)

  • Yes
  • No

Is Development Tested?

  • Yes
  • No

Tested in staging?

  • Yes
  • No

Add relevant Screenshot below ( e.g test coverage etc. )

screencast
demo-signup.mp4

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 1, 2026

Deploying www-rds with  Cloudflare Pages  Cloudflare Pages

Latest commit: e06c3a8
Status:🚫  Build failed.

View logs

@coderabbitai
Copy link

coderabbitai bot commented Jan 1, 2026

Walkthrough

The pull request simplifies the development mode handling in the new signup flow by removing the redundant signupDev flag. The dev query parameter now serves as the sole development mode indicator. The route's beforeModel gating logic that checked the dev flag has also been removed.

Changes

Cohort / File(s) Summary
Controller Logic Consolidation
app/controllers/new-signup.js
Removed signupDev tracked field and its entry from queryParams array. Updated isDevMode getter to check only this.dev === 'true' instead of referencing the now-removed signupDev.
Route Dev Mode Removal
app/routes/new-signup.js
Removed isDevMode property and beforeModel(transition) lifecycle method that previously gated access based on the dev query parameter and redirected to /page-not-found when dev was not 'true'.
Test Updates
tests/unit/controllers/new-signup-test.js
Updated dev flag test assertion from controller.signupDev = 'true' to controller.dev = 'true' to reflect the removed field.
Route Test Cleanup
tests/unit/routes/new-signup-test.js
Removed two unit tests that validated beforeModel redirect behavior: one for the /page-not-found redirect when dev is 'false', and one for allowing access when dev is 'true'.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 One flag was enough, we've learned,
No need for two when one has turned
The dev mode on, clean and bright—
Route gating bows to controller's might!
Simple wins the day, I say! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: removing the dev flag functionality from the new signup page across controllers, routes, and tests.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The PR description relates to the changeset by explaining the removal of the dev flag and replacement of signupDev with dev, matching the code changes in controllers, routes, and tests.
✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@MayankBansal12 MayankBansal12 self-assigned this Jan 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants