Feature flag removed : user OOO approve reject #1110

Dhirenderchoudhary · 2025-12-25T10:22:10Z

Date: 25-12-2025

Developer Name: Dhirender

Issue Ticket Number:-

Description:

The OOO feature is migrated from the user status page to the requests module by removing the dev=true feature flag. This change makes all OOO requests go through the approval workflow, ,so that no developer can change there OOO status by there own.

Is Under Feature Flag

Yes
No

Database changes

Yes
No

Breaking changes

Yes
No

Is Development Tested?

Yes
No

Tested in staging?

Yes
No

Screenshot below

coderabbitai · 2025-12-25T10:22:19Z

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

This PR removes dev mode feature flagging from user status components and consolidates the Out Of Office (OOO) workflow to exclusively use a dedicated createOOORequest method. The dev mode conditional logic is eliminated from components, templates, constants, and tests while maintaining existing OOO functionality through a unified request path.

Changes

Cohort / File(s)	Summary
Component Logic & API Updates `app/components/user-status-modal.js`, `app/constants/apis.js`	Removed `featureFlag` service dependency; simplified `updateStatusBasedOnMode` signature from `(isDevMode, newStateObj)` to `(newStateObj)`; updated OOO request invocation to use `newStateObj.from` and `newStateObj.until` instead of component properties; removed `dev=true` query parameter from `CREATE_OOO_REQUEST_URL` constant
Template & UI Updates `app/components/user-status.hbs`, `app/templates/status.hbs`, `app/components/user-status.js`	Removed `@dev`-based conditional branching for OOO button rendering; updated OOO option display text from "Change your status to OOO" to "Request OOO Status"; removed `@dev={{this.isDevMode}}` prop from component invocations
Test Updates `tests/integration/components/user-status-modal-test.js`, `tests/integration/components/user-status-test.js`	Replaced `@updateStatus` prop with `@createOOORequest` in UserStatusModal test; removed `@dev` and `isDevMode` test state; updated test assertions to validate `createOOORequest(from, until, reason)` payload structure; updated text assertion for OOO button label

Possibly related issues

website-dashboard#1033: Consolidates OOO workflow to use dedicated requests API path instead of dev-mode conditional status updates, aligning with the retrieved issue's OOO migration to /requests endpoint.
website-www#1109: Migrates OOO handling from direct status changes to a requests-based flow by routing through createOOORequest and updating the API constant, matching the retrieved issue's unified OOO workflow requirement.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 Away with dev flags, hop and bound,
The OOO path is now profound!
One method true, no branching ways,
Cleaner code through brighter days! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check	✅ Passed	The PR description clearly explains the migration of the OOO feature from the user status page to the requests module by removing the dev flag, aligning with the changeset modifications.
Title check	✅ Passed	The title 'Feature flag removed : user OOO approve reject' mentions feature flag removal and references OOO approval/rejection, which aligns with the PR's objective of removing the dev feature flag and migrating OOO to an approval workflow.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0f0b914 and 2179472.

📒 Files selected for processing (7)

app/components/user-status-modal.js
app/components/user-status.hbs
app/components/user-status.js
app/constants/apis.js
app/templates/status.hbs
tests/integration/components/user-status-modal-test.js
tests/integration/components/user-status-test.js

🧰 Additional context used

🧬 Code graph analysis (2)

tests/integration/components/user-status-modal-test.js (1)

tests/unit/controllers/status-test.js (6)

from (134-134)

from (179-179)

until (135-137)

until (180-182)

reason (138-138)

reason (183-183)

app/components/user-status-modal.js (1)

app/constants/user-status.js (2)

USER_STATES (18-24)

USER_STATES (18-24)

🔇 Additional comments (8)

app/components/user-status.js (1)

23-23: LGTM! UI text accurately reflects the new approval workflow.

The message change from "Change your status to OOO" to "Request OOO Status" correctly communicates that OOO now requires approval rather than being an immediate status change.

tests/integration/components/user-status-test.js (1)

49-49: LGTM! Test expectation correctly updated.

The test assertion correctly reflects the UI text change to "Request OOO Status".

app/components/user-status.hbs (1)

28-53: LGTM! Dev mode branching successfully removed.

The conditional logic now consistently renders OOO-related options without dev mode checks:

Shows "Cancel OOO" button when status is OOO

Shows available status options (including "Request OOO Status") for other statuses

This correctly implements the migration away from feature-flagged dev mode.

app/components/user-status-modal.js (2)

57-57: LGTM! Simplified method signature.

The removal of the isDevMode parameter from updateStatusBasedOnMode correctly reflects the elimination of dev mode branching logic.

107-117: LGTM! Logic correctly refactored from dev mode to status type.

The method now branches based on newStatus type rather than dev mode, which is the correct approach. For OOO status, it calls createOOORequest with the timestamp fields from newStateObj, and for other statuses, it calls updateStatus with the complete status object.

tests/integration/components/user-status-modal-test.js (1)

56-73: LGTM! Test correctly validates the new createOOORequest API.

The test properly validates the new OOO request flow:

Handler signature matches createOOORequest(from, until, reason)

Validates reason is passed correctly

Validates from and until are numeric timestamps

Component receives the @createOOORequest prop

Also applies to: 81-81

app/templates/status.hbs (1)

9-9: The controller correctly implements the createOOORequest action.

The status controller implements createOOORequest at line 70 with the expected signature (from, until, reason). The action properly converts date parameters, makes the API request to CREATE_OOO_REQUEST_URL, and handles responses with appropriate toast notifications. The updateStatus action remains in place for non-OOO status flows.

app/constants/apis.js (1)

38-38: The endpoint integration is properly implemented in the frontend; backend confirmation is needed separately.

The CREATE_OOO_REQUEST_URL endpoint is correctly configured without the dev=true parameter and consistently used across the codebase. The POST request includes proper error handling and request validation. However, verification that the backend /requests endpoint exists and properly handles OOO request creation requires confirmation from the backend service, which is outside the scope of code review.

tests/integration/components/user-status-modal-test.js

app/constants/apis.js

app/components/user-status-modal.js

tests/integration/components/user-status-modal-test.js

MayankBansal12 · 2025-12-25T13:36:22Z

@Dhirenderchoudhary

Please improve PR title and link issue correctly
Please attach screen recording for working of your feature
Build is failing please fix the test

app/components/user-status.js

app/constants/apis.js

MayankBansal12 · 2025-12-28T20:36:19Z

app/components/user-status-modal.js

    } else {
      await this.args.updateStatus({ currentStatus: newStateObj });
    }


any other case where code would reach this else statement? we can only change status to OOO, is there any other status available?

MayankBansal12 · 2025-12-28T20:37:39Z

@Dhirenderchoudhary

Please improve PR title, see other merged PRs for reference
One test is failing in CI, kindly look into that

* Feature flag removed : user OOO approve reject (#1110) * code changes OOO flow Migrated from users page to request flow * removed console log * changed assert.expect * fix: pass date strings instead of timestamps to createOOORequest * fixed errors * wrong commit fix * removed else * removed stateobj --------- Co-authored-by: Dhirenderchoudhary <dhirenderchoudhary0001@gmailcom> * fix: OOO migration date issues (#1112) * fixed date issues * fix lint --------- Co-authored-by: Dhirenderchoudhary <dhirenderchoudhary0001@gmailcom> * fix: Update OOO request button text (#1116) * message changed * message fix * lint fix --------- Co-authored-by: Dhirenderchoudhary <dhirenderchoudhary0001@gmailcom> --------- Co-authored-by: Dhirender Choudhary <[email protected]> Co-authored-by: Dhirenderchoudhary <dhirenderchoudhary0001@gmailcom>

code changes OOO flow Migrated from users page to request flow

2179472

coderabbitai bot reviewed Dec 25, 2025

View reviewed changes

tests/integration/components/user-status-modal-test.js Outdated Show resolved Hide resolved

MayankBansal12 reviewed Dec 25, 2025

View reviewed changes

app/constants/apis.js Show resolved Hide resolved

app/components/user-status-modal.js Outdated Show resolved Hide resolved

tests/integration/components/user-status-modal-test.js Outdated Show resolved Hide resolved

Dhirenderchoudhary added 2 commits December 25, 2025 19:07

removed console log

f77f5c6

changed assert.expect

28524a7

Dhirenderchoudhary changed the title ~~code changes OOO flow Migrated from users page to request flow~~ Migrate OOO Flow to Requests. Dec 25, 2025

fix: pass date strings instead of timestamps to createOOORequest

fc33967

Dhirenderchoudhary force-pushed the Migarted_OOO_flow branch from c9f005b to fc33967 Compare December 27, 2025 13:23

MayankBansal12 reviewed Dec 28, 2025

View reviewed changes

Dhirenderchoudhary changed the title ~~Migrate OOO Flow to Requests.~~ Feature flag removed : user OOO approve reject Dec 28, 2025

fixed errors

402536d

Dhirenderchoudhary force-pushed the Migarted_OOO_flow branch from 1b82479 to 402536d Compare December 29, 2025 14:47

wrong commit fix

df9d744

Dhirenderchoudhary force-pushed the Migarted_OOO_flow branch from ed635d9 to df9d744 Compare December 29, 2025 17:31

removed else

fe29f99

Dhirenderchoudhary force-pushed the Migarted_OOO_flow branch from 0efc272 to fe29f99 Compare December 30, 2025 21:25

removed stateobj

a727041

Dhirenderchoudhary force-pushed the Migarted_OOO_flow branch from eeea17e to a727041 Compare December 30, 2025 21:48

Merge branch 'develop' into Migarted_OOO_flow

322ca7e

Hariom01010 approved these changes Dec 30, 2025

View reviewed changes

iamitprakash approved these changes Dec 31, 2025

View reviewed changes

iamitprakash merged commit 9108de8 into RealDevSquad:develop Dec 31, 2025
3 checks passed

coderabbitai bot mentioned this pull request Dec 31, 2025

fix: OOO migration date issues #1112

Merged

10 tasks

MayankBansal12 mentioned this pull request Dec 31, 2025

Dev to Main Sync #1113

Merged

10 tasks

coderabbitai bot mentioned this pull request Jan 1, 2026

fix: Update OOO request button text #1116

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Feature flag removed : user OOO approve reject #1110

Feature flag removed : user OOO approve reject #1110

Uh oh!

Dhirenderchoudhary commented Dec 25, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Dec 25, 2025 •

edited

Loading

Review skipped

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MayankBansal12 commented Dec 25, 2025

Uh oh!

Uh oh!

Uh oh!

MayankBansal12 Dec 28, 2025

Uh oh!

MayankBansal12 commented Dec 28, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Feature flag removed : user OOO approve reject #1110

Feature flag removed : user OOO approve reject #1110

Uh oh!

Conversation

Dhirenderchoudhary commented Dec 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue Ticket Number:-

Description:

Screenshot below

Uh oh!

coderabbitai bot commented Dec 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Walkthrough

Changes

Possibly related issues

Estimated code review effort

Poem

Pre-merge checks and finishing touches

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MayankBansal12 commented Dec 25, 2025

Uh oh!

Uh oh!

Uh oh!

MayankBansal12 Dec 28, 2025

Choose a reason for hiding this comment

Uh oh!

MayankBansal12 commented Dec 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Dhirenderchoudhary commented Dec 25, 2025 •

edited

Loading

coderabbitai bot commented Dec 25, 2025 •

edited

Loading

MayankBansal12 commented Dec 28, 2025 •

edited

Loading