-
Notifications
You must be signed in to change notification settings - Fork 153
feat: add new step 2 and 3 for intro and interests [Onboarding-Form] #1084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
e59f8be to
7f7bab0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Status |
|---|---|---|
| Redundant maxWords Object ▹ view | ||
| Inconsistent Text Formatting Style ▹ view | ||
| Redundant property access in maxWords object ▹ view |
Files scanned
| File Path | Reviewed |
|---|---|
| app/components/new-join-steps/new-step-two.js | ✅ |
| app/components/new-join-steps/new-step-three.js | ✅ |
| app/constants/new-join-form.js | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
fa00939 to
317b529
Compare
47d1939 to
6b9cf3c
Compare
00fd80e to
e5edda0
Compare
ae7a49b to
ee06d8a
Compare
7ecf73e to
1b8f477
Compare
…ing-Form] (#1086) * feat: add new step for social links * feat: add snew step four for social links * feat: add new step fivve for stepper * fix: styling for selectt in new step five * refactor: replace hardcoded storage keys with constants * feat: add review step for new stepper [Onboarding-Form] (#1087) * feat: add review step for new stepper * feat: add thank you screen for new stepper * refactor: use structure for step data and replace hardcoded storage keys * refactor: use getter func for review step button
* feat: add step one for image upload and personal details * fix: styling for form header * fix: styling for image box and input boxes * feat: add prev and next stepper buttons * fix: incorrect data testt for stepper buttons * feat: add base step component for all new steps * fix: input validation in new step one * refactor: improve progress calculation and update header text * refactor: improve step navigation * fix: image upload preview and update storage keys * refactor: use try catch in local storage actions * refactor: improve accessibility in new step one * refactor: enhance image upload and new stepper error handling * refactor: validation for fields in new stepper and enhance button layout * feat: add new step 2 and 3 for intro and interests [Onboarding-Form] (#1084) * feat: add new step two for introduction * feat: add step three for interests * feat: add base step class to handle input validation and local storage sync * fix: postIntialization in new step one * fix: grid styling for step two and three * refactor: remove redundant max words * fix: lint issue and form headings * refactor: use constant for storage keys * feat: add new step four and five for social links and whyRds [Onboarding-Form] (#1086) * feat: add new step for social links * feat: add snew step four for social links * feat: add new step fivve for stepper * fix: styling for selectt in new step five * refactor: replace hardcoded storage keys with constants * feat: add review step for new stepper [Onboarding-Form] (#1087) * feat: add review step for new stepper * feat: add thank you screen for new stepper * refactor: use structure for step data and replace hardcoded storage keys * refactor: use getter func for review step button
Date: 03-11-25
Developer Name: @MayankBansal12
Issue Ticket Number:-
Description:
Is Under Feature Flag
Database changes
Breaking changes (If your feature is breaking/missing something please mention pending tickets)
Is Development Tested?
Tested in staging?
Add relevant Screenshot below ( e.g test coverage etc. )
screencast
step2-3.mp4
tests