-
Notifications
You must be signed in to change notification settings - Fork 153
feat: change fields for OOO request based on the new model #1069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Summary by CodeRabbit
WalkthroughThe changes update API backend URLs for development and test environments to use a local server and modify the request body keys in a status update action, renaming Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🧰 Additional context used🧠 Learnings (2)📓 Common learningsapp/controllers/status.js (1)🧬 Code Graph Analysis (1)app/controllers/status.js (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (3)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Status |
|---|---|---|
| Non-configurable API URL in test environment ▹ view | 🧠 Incorrect |
Files scanned
| File Path | Reviewed |
|---|---|
| app/controllers/status.js | ✅ |
| app/constants/urls.js | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
| MY_STATUS: `${SCHEME}staging-my.${DOMAIN}`, | ||
| DASHBOARD: `${SCHEME}staging-dashboard.${DOMAIN}`, | ||
| API_BACKEND: `${SCHEME}staging-api.${DOMAIN}`, | ||
| API_BACKEND: `http://localhost:3000`, |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Date:
change date hereDeveloper Name:
developer name hereIssue Ticket Number:-
#923Description:
Add description of the PR here
Is Under Feature Flag
Database changes
Breaking changes (If your feature is breaking/missing something please mention pending tickets)
Is Development Tested?
Tested in staging?
Add relevant Screenshot below ( e.g test coverage etc. )
Description by Korbit AI
What change is being made?
Update the URL for
API_BACKENDtohttp://localhost:3000in the development and production environments and modify the fields for the Out-Of-Office (OOO) request in theStatusController.Why are these changes being made?
The API endpoint is being changed to
localhostto facilitate local development, possibly indicating a shift away from using a staging domain for testing. The fields for the OOO request are updated to reflect a new model, changingmessagetoreasonandstatetostatus, which aligns the code structure with the new specifications for OOO requests.