Skip to content

Conversation

@Yashrane25
Copy link

@Yashrane25 Yashrane25 commented Jun 9, 2025

Date: 09-06-2025

Developer Name: Yash Rane
🎉 This is my first pull request to this repository!


Issue: #853:-

Fixes issue with dropdown links opening in a new tab instead of the same tab.

Description:

This PR removes target="_blank" from the dropdown menu links (Status, Profile, Tasks, Identity) so that they now open in the same tab instead of a new tab. This aligns with user expectations for navigation within the same application.

Also ensures rel="noopener noreferrer" is retained for security where applicable.

Is Under Feature Flag:

  • Yes
  • No

Database changes:

  • Yes
  • No

Breaking changes:

  • Yes
  • No

Is Development Tested?

  • Yes
  • No

Tested in staging?

  • Yes
  • No

Screenshot / Proof:

UI behavior verified manually (click events open in same tab).

Screenshot 2025-06-09 135819

Screenshot 2025-06-09 135851

Description by Korbit AI

What change is being made?

Remove target='_blank' attribute from dropdown menu links to open them in the same tab.

Why are these changes being made?

The change was made to provide a more streamlined navigation experience by opening dropdown links in the same tab, avoiding the disruption of context switching to a new browser tab. This improves user experience by maintaining navigation consistency across the application.

Is this description stale? Ask me to generate a new description by commenting /korbit-generate-pr-description

@coderabbitai
Copy link

coderabbitai bot commented Jun 9, 2025

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Summary by CodeRabbit

  • Style

    • Updated internal comments for improved clarity in the dropdown menu section.
  • Bug Fixes

    • Updated dropdown menu links so they no longer open in a new tab. All links now open in the same browser tab.

Walkthrough

The update introduces a comment above the dropdown menu section in the header template for clarity. Additionally, it removes the target="_blank" attribute from all relevant anchor and LinkTo elements within the dropdown, affecting navigation links like Home, Status, Profile, Tasks, and Identity.

Changes

File Change Summary
app/components/header.hbs Added a comment above the dropdown; removed target="_blank" from dropdown navigation links.

Poem

In the header where menus reside,
A comment now sits, with nothing to hide.
No more new tabs when links are clicked,
Navigation’s simple, no windows picked.
The dropdown’s refreshed, neat and clear—
Just a small change, but worth a cheer!
🐇✨

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review and didn't find any issues... but I did find this penguin.

 __
( o>
///\
\V_/_

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

@devoleper-samreen
Copy link

Hi! I’d love to work on this issue. Can you please assign it to me? 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants