Skip to content
This repository was archived by the owner on Mar 1, 2025. It is now read-only.

fix: cursor is pointer when superuser hover over users #470

Open
prankurpandeyy wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

fix: cursor is pointer when superuser hover over users #470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2a217a7
fix: cursor is pointer when superuser hover over users
prankurpandeyy Nov 1, 2022
616aa5a
cursor is pointer when hovered on new user images
prankurpandeyy Nov 1, 2022
06a56d6
cursor is pointer when hovered on new user images
prankurpandeyy Nov 2, 2022
ec2fc27
updated the className in CSS fie
prankurpandeyy Nov 8, 2022
3c5179c
updated the border in CSS file
prankurpandeyy Nov 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/components/new-members/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,15 @@ import { userContext } from '@store/user/user-context';

// returns card which shows details of new member
const renderNewUserCard = (newMember) => {
const { isSuperUser } = userContext();
return (
<div className={styles.containerForNewMember}>
<div
className={
isSuperUser
? styles.superUserContainerForNewMember
: styles.containerForNewMember
}
>
<Card developerInfo={newMember} isMember={false} />
</div>
);
Expand Down
6 changes: 5 additions & 1 deletion src/components/new-members/new-members.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
}

.newUser {
pointer-events: none;
pointer-events: auto;
Copy link
Contributor

@harshith-venkatesh harshith-venkatesh Nov 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the expectation, only super user should perform some action on pointer event and rest shouldn't?
Clarify in case I am thinking wrong here

Copy link
Author

@prankurpandeyy prankurpandeyy Nov 2, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes anyone with a super user role should be able to have a cursor pointer property for the rest of the users it should be the default cursor pointer.

display: flex;
padding: 20px 10px;
background: white;
Expand Down Expand Up @@ -40,3 +40,7 @@
box-shadow: none;
}
}
.superUserContainerForNewMember {
@extend .containerForNewMember;
Copy link
Contributor

@harshith-venkatesh harshith-venkatesh Nov 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive 🙌
Good use of @extend

Copy link
Author

@prankurpandeyy prankurpandeyy Nov 2, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review.

cursor: pointer;
}