Skip to content

Fix : Today's date allowed while creation OOO #2529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iamitprakash merged 10 commits into from
Jan 3, 2026
Merged

Fix : Today's date allowed while creation OOO #2529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
af77185
feature flag removed for OOO creation
Dec 27, 2025
bf60cee
removed a statement
Dec 27, 2025
05c1f01
Revert "feature flag removed for OOO creation"
Dec 28, 2025
4637ba5
changes for feature flag removal
Dec 28, 2025
5337819
fixed error
Dec 28, 2025
435a30d
errors fixed
Dec 29, 2025
d4be027
everything fixed and checked
Dec 30, 2025
7b6df51
fixed date logic for today's OOO creation
Jan 3, 2026
ec2dd41
merge error fix
Jan 3, 2026
4e5770a
UTC added sethours
Jan 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion middlewares/validators/oooRequests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export const createOooStatusRequestValidator = async (
.keys({
from: joi
.number()
.min(Date.now())
.min(new Date().setUTCHours(0, 0, 0, 0))
.messages({
"number.min": "from date must be greater than or equal to Today's date",
})
Expand Down
1 change: 0 additions & 1 deletion test/integration/requests.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,7 +425,6 @@ describe("/requests OOO", function () {
done();
});
});

it("should approve OOO request", function (done) {
chai
.request(app)
Expand Down
4 changes: 2 additions & 2 deletions test/unit/middlewares/oooRequests.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ describe("OOO Status Request Validators", function () {
res = {};

await createOooStatusRequestValidator(req as any, res as any, nextSpy);
expect(nextSpy.calledOnce);
expect(nextSpy.notCalled).to.be.true;
});

it("should not validate for an invalid request on wrong type", async function () {
Expand Down Expand Up @@ -82,7 +82,7 @@ describe("OOO Status Request Validators", function () {

it("should not validate for an invalid request if all until date is greater than from", async function () {
req = {
body: { ...validOooStatusRequests, from: Date.now() + 5000000, until: Date.now() + 1000000 },
body: { ...validOooStatusRequests, from: new Date().setUTCHours(0, 0, 0, 0) + 5000000, until: new Date().setUTCHours(0, 0, 0, 0) + 1000000 },
};
try {
await createOooStatusRequestValidator(req as any, res as any, nextSpy);
Expand Down
Loading