Dev to Main Sync #2519
Merged
Dev to Main Sync #2519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix(progresses): enforce discord membership for progress updates - block POST /progresses when the requester is archived or lacks in_discord role - adjust test fixtures to model active members and add a regression test rejecting non-discord users * fix(progresses): restrict updates to active discord members - reject POST /progresses when roles.archived is true or roles.in_discord is not true - centralize Discord-member test fixture helper and re-use it across progress integration suites - add regression test proving non-Discord users receive UNAUTHORIZED_WRITE
Main to Dev Sync
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Achintya-Chatterjee
requested review from
ankushdharkar,
iamitprakash,
prakashchoudhary07 and
yesyash
iamitprakash
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date:
December 12, 2025Developer Name: @Achintya-Chatterjee
Issue Ticket Number
/progresses POSTendpoint to Discord members #2518PR's Going in this Sync
Description
POST /progresseswhenroles.archivedistrueorroles.in_discordis not trueDocumentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Screenshot 1
Screen.Recording.2025-12-12.at.00.16.40.mp4
Test Coverage
Screenshot 1
Additional Notes