Tests for fetchProfileDiffUnobfuscated and filtering out id in addOrUpdate #2256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
Author
|
Stacked PR Containing test for #2253 |
10 tasks
RahulGoyal-tech
changed the title
Achintya-Chatterjee
suggested changes
Dec 1, 2024
Achintya-Chatterjee
approved these changes
Dec 17, 2024
MehulKChaudhari
approved these changes
Dec 17, 2024
Contributor
|
this should be in one pr #2253 |
Contributor
Author
Had a conversation in beginning with achintya. Planned at that time to make this stacked. |
Contributor
I don't think it needed stacked pr here. |
Contributor
Author
Yeah it could be encapsulated in one pr itself as well. Please review and approve this. Will try to keep single pr for simpler ones from next time. |
pankajjs
pushed a commit
to pankajjs/website-backend
that referenced
this pull request
Dec 21, 2024
…pdate (RealDevSquad#2256) * Added test for id filterin in addOrUpdate * Added Tests for Unobfuscated details and filtered id * Updated test to match fixture instead of Regex * Added test for id filterin in addOrUpdate * Added Tests for Unobfuscated details and filtered id * Updated test to match fixture instead of Regex * Removed comments * Test Cases Added * Added nested profileDiff --------- Co-authored-by: Prakash Choudhary <[email protected]> Co-authored-by: Achintya Chatterjee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date: 18-11-2024
Developer Name: Rahul Goyal
Issue Ticket Number
#2223
Description
Added tests for the PR #2253
profileDiffs.jsmodel to testfetchProfileDiffUnobfuscated.{ profileDiffExists : false }if invalid diff id.{ profileDiffExists : true }if given valid diff id.Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Test Coverage
Screenshot 1