Feat: Super users can delete discord group roles #2241
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
VaibhavSingh8
changed the title
Try to be in Discord so we can track this, ask @ankushdharkar for further assistance |
This is failing. |
|
Test is missing for controller. |
vinit717
left a comment
vinit717
left a comment
There was a problem hiding this comment.
Add a proper test coverage and tests of the code you made
@vinit717 Can you please elaborate more on this as in what to add? |
Proper test coverage report of the code/file you changed |
@vinit717 updated the reports in the PR description. Do I need to add tests for the controller too, because I can't find any written earlier for any controller? |
Integration test itself is controller tests make logic parts in models so you can test it |
Hi @vinit717 I've implemented the requested changes. Please review the PR. Thank you! |
|
Are we not integrating the Discord API as we discussed? @VaibhavSingh8 |
The timeline for this PR is concise, so as I requested yesterday, let's proceed with the original advice by Ankush to do it in a separate PR. |
|
Okay, I will pick in new task. |
|
Left few comments @VaibhavSingh8 |
|
-In the working video, include the discord part as well. |
Fixed |
…use devFlag middleware
VaibhavSingh8
requested review from
Achintya-Chatterjee,
vikasosmium and
vikhyat187
and removed request for
vikasosmium and
vikhyat187
* added route, controller and model for deleting the group role * added route, controller and model for deleting the group role * unit tests for deleteGroupRole * updated unit tests for deleteGroupRole * integrated feature flag * chore: roleid fetch from firestore and removed console logs * integration tests for deleteGroupRole * fix: reduced db calls from 2 to 1 for roleId * feat: integrated discord service to delete role from discord * test: unit and integration tests for discord service integration * chore: refactored controller and tests to use res.boom and routes to use devFlag middleware * fix: error code
4 participants
Date: 04 Nov 2024
Developer Name: @VaibhavSingh8
Issue Ticket Number
Description
This PR implements the ability for super users to delete Discord groups through the
/groupsendpoint on the dashboard site. This feature allows for better group management.deleteGroupRolemodel function to handle the soft deletion of group roles in the Firestore database.isDeleted: truealong with deletion metadata.Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Screenshot 1
test-1.mp4
test-2.mp4
Test Coverage
Screenshot 1
Additional Notes