Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions todo/services/team_service.py
Original file line number Diff line number Diff line change
Expand Up @@ -358,11 +358,11 @@ def update_team(cls, team_id: str, poc_id: str, user_id: str) -> TeamDTO:
if not updated_team:
raise ValueError(f"Failed to update team with id {team_id}")

# Audit log for team update
# Audit log for POC change
AuditLogRepository.create(
AuditLogModel(
team_id=PyObjectId(team_id),
action="team_updated",
action="poc_changed",
performed_by=PyObjectId(user_id),
)
)
Expand Down
27 changes: 27 additions & 0 deletions todo/tests/unit/services/test_team_service.py
Original file line number Diff line number Diff line change
Expand Up @@ -415,3 +415,30 @@ def test_update_team_poc_not_team_member_raises_error(
self.assertIn("User is not a member of the team", str(result))
self.assertEqual(mock_has_role.call_count, 2)
mock_has_role.assert_any_call(self.member_id, RoleName.MEMBER.value, RoleScope.TEAM.value, self.team_id)

@patch("todo.services.team_service.TeamRepository.get_by_id")
@patch("todo.services.team_service.TeamRepository.update")
@patch("todo.services.team_service.AuditLogRepository.create")
@patch("todo.repositories.user_repository.UserRepository.get_by_id")
@patch("todo.services.team_service.UserRoleService.has_role")
def test_update_team_creates_poc_changed_audit_log(
self, mock_has_role, mock_user_get, mock_audit_log_create, mock_team_update, mock_team_get
):
mock_team_get.return_value = self.team_model
mock_team_update.return_value = self.team_model
mock_user_get.return_value = self.user_model
mock_has_role.return_value = True

TeamService.update_team(
team_id=self.team_id,
poc_id=self.member_id,
user_id=self.owner_id,
)

mock_audit_log_create.assert_called_once()

audit_log_model = mock_audit_log_create.call_args[0][0]

self.assertEqual(audit_log_model.action, "poc_changed")
self.assertEqual(audit_log_model.team_id, PyObjectId(self.team_id))
self.assertEqual(audit_log_model.performed_by, PyObjectId(self.owner_id))