-
Notifications
You must be signed in to change notification settings - Fork 272
Dev to Main Sync #2377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev to Main Sync #2377
Conversation
* fix: remove feature flag from onboarding extension request features * test: update tests after removing feature flag from onboarding extension
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This is staging proof for pr #2382 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update all desc
Date: 7 Feb, 2025
Developer Name: @pankajjs @AnujChhikara @mbramani
Issue Ticket Number
Description
@pankajjs's change fixes error handler middleware to send error response.
@mbramani's change removes feature flag from
POST /requests
,PUT /requests/id
, andPATCH /requests/id
endpoints for onboarding extension feature.@AnujChhikara's change removes feature flag from progress api and adds a default size(5) for
GET /extension-requests
endpoint when user does not pass any size.PR going to Sync
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Screenshots
Onboarding Extension FeatureShareX_HRQ93QoxtT.mp4
You we can see we are returning the userdata in the response without the dev flag
Test Coverage
Screenshots
Additional Notes