feat: Add an API to edit onboarding extension request details before approval or rejection #2334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
pankajjs
force-pushed
the
feat/add-api-to-edit-request
branch
from
acb162a to
82d007e
Compare
10 tasks
pankajjs
force-pushed
the
feat/add-api-to-edit-request
branch
4 times, most recently
from
05611b1 to
eb86437
Compare
pankajjs
force-pushed
the
feat/add-api-to-edit-request
branch
from
eb86437 to
31c470b
Compare
pankajjs
force-pushed
the
feat/add-api-to-edit-request
branch
2 times, most recently
from
a6d4a6f to
29ebf36
Compare
pankajjs
force-pushed
the
feat/add-api-to-edit-request
branch
2 times, most recently
from
3d2b451 to
67df348
Compare
pankajjs
force-pushed
the
feat/add-api-to-edit-request
branch
2 times, most recently
from
a8eb8c6 to
c0742e5
Compare
Achintya-Chatterjee
requested changes
Jan 16, 2025
pankajjs
force-pushed
the
feat/add-api-to-edit-request
branch
from
486a3de to
e310f96
Compare
Achintya-Chatterjee
changed the title
shobhan-sundar-goutam
suggested changes
Jan 17, 2025
pankajjs
force-pushed
the
feat/add-api-to-edit-request
branch
3 times, most recently
from
d291fd9 to
3c05d2f
Compare
shobhan-sundar-goutam
approved these changes
Jan 19, 2025
pankajjs
force-pushed
the
feat/add-api-to-edit-request
branch
4 times, most recently
from
815b44b to
da8e21a
Compare
- Add common validator to redirect request based on type of extension - Add type field in onboarding extension validator - Import addLog from services to make it available for stubbing while testing - Moved response messages to constants file - Reuse single instance of current date in request and log model for consistent data - Change controller name - Remove unused variables - Add authorization check for superuser or request ownership - Change authorization condition - Remove unnecessary changes
pankajjs
force-pushed
the
feat/add-api-to-edit-request
branch
from
da8e21a to
80bdeb4
Compare
iamitprakash
added a commit
that referenced
this pull request
Jan 26, 2025
* chore: remove duplicate function call for onboarding extension request (#2361) * feat: Implement Pagination for GET /progreses API (#2325) * feat: add pagination to GET /progreses API * fix returning 404 on a page with no data * fix joi validator logic * refactor getting totalcount logic * fix dev true * fix merge conflicts * using constant * maked the JsDoc more concise --------- Co-authored-by: Vinit khandal <[email protected]> * test : add tests for pagination of progresses api (#2328) * added test for the get progresses pagination * added test for dev=false * minor fix * added unit test for utils/progresses functions * added progressed model unit tests * added test for 500 * added 500 message from constant * fix test naming * feat: Add an API to edit onboarding extension request details before approval or rejection (#2334) * feat: Add feature to update request before approval or rejection - Add common validator to redirect request based on type of extension - Add type field in onboarding extension validator - Import addLog from services to make it available for stubbing while testing - Moved response messages to constants file - Reuse single instance of current date in request and log model for consistent data - Change controller name - Remove unused variables - Add authorization check for superuser or request ownership - Change authorization condition - Remove unnecessary changes * fix: add logs for failure cases and fix check for same old and new deadline * refactor: separate validation and update logic in service file * chore: fix jsDoc * fix: send id instead of while request doc while updating it * chore: fix lint issue * fix: change validation response condition and fix jsDoc * fix: add strict checking * fix: change constant message * feat: Add tests for PATCH /requests/:id API for onboarding extension requests (#2335) * feat: Add test cases for controller and validator - Remove failing tests and fix existing tests - Add tests to check success and unexpected behaviour and fix existing tests - Replace actual messages with constants for easily maintenance - Add test for super user and request owner authorization check and fix existing failing tests - Remove un-necessary changes - Remove separate file for validator tests * feat: add tests for onboarding update and validate service * Merge pull request #2369 from pankajjs/fix/flaky-test Fix flaky test present in PR[2335] * fix: handle id query parameter in Get Requests API (#2367) Co-authored-by: Vikas Singh <[email protected]> Co-authored-by: Achintya Chatterjee <[email protected]> --------- Co-authored-by: Yash Raj <[email protected]> Co-authored-by: Pankaj <[email protected]> Co-authored-by: Anuj Chhikara <[email protected]> Co-authored-by: Vinit khandal <[email protected]> Co-authored-by: Vikas Singh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date: 3 Dec, 2025
Developer Name: @pankajjs
Issue Ticket Number
Description
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Screenshots
Test Coverage
Test coverage has been added in test PR #2335
Additional Notes