Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement mergeDelayError #206

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Implement mergeDelayError #206

wants to merge 5 commits into from

Conversation

mbonneau
Copy link
Member

@mbonneau mbonneau commented Mar 4, 2020

Implement #205.

Items in this PR that may need discussion are what to do about errors occurring on multiple observables and whether this should be implemented as a mergeAll type operator that merges a sequence of observables.

The the multiple error issue: it looks like the Java flavored Rx implementations use a CompositeException that gets emitted onError. We could implement a similar functionality.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0003%) to 99.4% when pulling 5b78c8b on mbonneau:mergeDelayError into 3c760ba on ReactiveX:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.0003%) to 99.4% when pulling 5b78c8b on mbonneau:mergeDelayError into 3c760ba on ReactiveX:master.

@mbonneau mbonneau requested a review from davidwdan June 12, 2020 01:49
@mbonneau
Merge changes into mergeDelayError
c7099b2 
# Conflicts:
#	.travis.yml
#	composer.json
@mbonneau
Delete .travis.yml
c4ebbed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwdan davidwdan Awaiting requested review from davidwdan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbonneau @coveralls