Skip to content

Commit

Permalink
PHP 8.2 compatibility (#215)
Browse files Browse the repository at this point in the history
* Test on PHP 8.2

* Turn off fail fast so we can see all errors

* Declare disposable property on scheduled item

This fixes the following error on 8.2:
```
Deprecated: Creation of dynamic property Rx\Scheduler\ScheduledItem::$disposable is deprecate
```
  • Loading branch information
WyriHaximus authored Sep 10, 2022
1 parent 6e769ab commit ecfed5e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,13 @@ jobs:
name: PHPUnit (PHP ${{ matrix.php }} on ${{ matrix.os }})
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
os:
- ubuntu-20.04
- windows-2019
php:
- 8.2
- 8.1
- 8.0
- 7.4
Expand Down
1 change: 1 addition & 0 deletions src/Scheduler/ScheduledItem.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ class ScheduledItem
private $action;
private $dueTime;
private $comparer;
private $disposable;

public function __construct($scheduler, $state, $action, $dueTime, $comparer = null)
{
Expand Down

0 comments on commit ecfed5e

Please sign in to comment.