-
-
Notifications
You must be signed in to change notification settings - Fork 850
feat: Improve bundle info screen design #2548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: compose-dev
Are you sure you want to change the base?
feat: Improve bundle info screen design #2548
Conversation
Currently the page looks like this: #2497 (comment) |
app/src/main/java/app/revanced/manager/ui/component/bundle/BaseBundleDialog.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/app/revanced/manager/patcher/patch/PatchBundle.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code seems good. Just need approval from designers.
7338157
to
70a6950
Compare
This also needs to be rebased. |
May close ReVanced#2497 when we agree on how to do it.
d1d9c05
to
9066c11
Compare
I didn't received much feedbacks, I've made the icon white/black (based on theme) and not grey, and also used the bundle name as the page title. |
Perhaps this page (or the view patches page) can also have a "Use patches" function when clicked, it leads to the app selector screen, short circuiting the navigation to there for ease of access. |
Asking your review for the look and feel of this page. @validcube @Ushie I can adjust as Osu said, if you think it's better. |
May close #2497 when we agree on how to do it.