Skip to content

feat: Improve bundle info screen design #2548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: compose-dev
Choose a base branch
from

Conversation

brosssh
Copy link
Member

@brosssh brosssh commented May 14, 2025

May close #2497 when we agree on how to do it.

@brosssh
Copy link
Member Author

brosssh commented May 14, 2025

Currently the page looks like this: #2497 (comment)

@Axelen123 Axelen123 added the ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager label May 15, 2025
@brosssh
Copy link
Member Author

brosssh commented May 18, 2025

Still up to discussing how the page should look, currently it's like this.

Screenshot_2025-05-18-17-23-49-13_761fe8f2c59677c7476dd46708cfb34f.jpg

Screenshot_2025-05-18-17-23-55-59_761fe8f2c59677c7476dd46708cfb34f.jpg

@brosssh brosssh requested a review from Axelen123 May 18, 2025 15:29
Copy link
Member

@Axelen123 Axelen123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code seems good. Just need approval from designers.

@Ushie Ushie changed the title feat(Compose): Refactor of bundle info page feat: Refactor of bundle info page May 20, 2025
@Ushie Ushie changed the title feat: Refactor of bundle info page feat: Improve bundle info screen design May 20, 2025
@oSumAtrIX oSumAtrIX force-pushed the compose-dev branch 3 times, most recently from 7338157 to 70a6950 Compare May 22, 2025 12:16
@Axelen123
Copy link
Member

This also needs to be rebased.

@brosssh brosssh force-pushed the feat/compose/refactor-bundle-info-page branch from d1d9c05 to 9066c11 Compare May 26, 2025 06:16
@brosssh
Copy link
Member Author

brosssh commented Jun 2, 2025

I didn't received much feedbacks, I've made the icon white/black (based on theme) and not grey, and also used the bundle name as the page title.

@brosssh
Copy link
Member Author

brosssh commented Jun 2, 2025

Page is like this now:
Screenshot_2025-06-02-19-51-20-06_761fe8f2c59677c7476dd46708cfb34f.jpg

Personally I like it more like this:
Screenshot_2025-06-02-19-53-57-46_761fe8f2c59677c7476dd46708cfb34f.jpg

@oSumAtrIX
Copy link
Member

How about the title saying "View patches" and the description "View all X patches" or something similar
image

@oSumAtrIX
Copy link
Member

oSumAtrIX commented Jun 2, 2025

Perhaps this page (or the view patches page) can also have a "Use patches" function when clicked, it leads to the app selector screen, short circuiting the navigation to there for ease of access.

@brosssh brosssh requested review from Ushie and validcube June 6, 2025 09:37
@brosssh
Copy link
Member Author

brosssh commented Jun 6, 2025

Asking your review for the look and feel of this page. @validcube @Ushie

I can adjust as Osu said, if you think it's better.

@brosssh brosssh linked an issue Jun 16, 2025 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Set patch bundle title to patch bundle name & version
3 participants