feat: Rename "Patch bundle" to "Patches" #2541
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oSumAtrIX
requested review from
Axelen123 and
Ushie
and removed request for
Axelen123
Axelen123
added
the
ReVanced Manager Compose
Axelen123
requested changes
May 11, 2025
app/build.gradle.kts
Outdated
There was a problem hiding this comment.
I don't think the project will build with these changes.
| @@ -77,7 +77,7 @@ enum class DashboardPage( | |||
| val icon: ImageVector | |||
| ) { | |||
| DASHBOARD(R.string.tab_apps, Icons.Outlined.Apps), | |||
| BUNDLES(R.string.tab_bundles, Icons.Outlined.Source), | |||
| BUNDLES(R.string.tab_patches, Icons.Outlined.Source), | |||
There was a problem hiding this comment.
The name of the enum variant wasn't changed.
| @@ -132,8 +130,8 @@ | |||
| <string name="reset_patch_selection_success">Patch selection has been reset</string> | |||
| <string name="patch_options_reset_package">Reset patch options for app</string> | |||
| <string name="patch_options_reset_package_description">Resets patch options for a single app</string> | |||
| <string name="patch_options_reset_bundle">Resets patch options for bundle</string> | |||
| <string name="patch_options_reset_bundle_description">Resets patch options for all patches in a bundle</string> | |||
| <string name="patch_options_reset_patches">Resets patch options for this patches</string> | |||
There was a problem hiding this comment.
"for this patches" doesn't sound right.
Comment on lines
-188
to
+189
| <string name="api_url_dialog_title">Set custom API URL</string> | ||
| <string name="api_url_dialog_description">Set the API URL of ReVanced Manager. ReVanced Manager uses the API to download patches and updates.</string> | ||
| <string name="api_url_dialog_title">Change API URL</string> | ||
| <string name="api_url_dialog_description">Change the API URL of ReVanced Manager. ReVanced Manager uses the API to download patches and updates.</string> |
There was a problem hiding this comment.
Are these changes within the scope of this PR?
oSumAtrIX
force-pushed
the
compose-dev
branch
3 times, most recently
from
7338157 to
70a6950
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optionally "Patches file" can be used.
For reference: https://discord.com/channels/952946952348270622/952987428786941952/1370824632156033185
For now, only strings are named. Code and internal changes can be made after Compose Manager release