chore: Merge branch `dev` to `main` #2468

revanced-bot · 2025-04-04T15:59:28Z

This pull request will Merge branch dev to main.

## [1.24.1-dev.1](v1.24.0...v1.24.1-dev.1) (2025-04-04) ### Bug Fixes * Crash using when Integer type in Patch Options ([#2453](#2453)) ([05575cc](05575cc))

Technical commit message: fix: Unable to Share Logs due to CCE in FileProvider Signed-off-by: Pun Butrach <[email protected]>

## [1.24.1-dev.2](v1.24.1-dev.1...v1.24.1-dev.2) (2025-04-09) ### Bug Fixes * Unable to Share Logs due to missing ProGuard rules ([#2474](#2474)) ([915ec0e](915ec0e))

Copilot

Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.

Files not reviewed (2)

android/app/proguard-rules.pro: Language not supported
lib/ui/widgets/patchesSelectorView/patch_options_fields.dart: Language not supported

Signed-off-by: Pun Butrach <[email protected]>

…ugging

Signed-off-by: Pun Butrach <[email protected]>

## [1.24.1-dev.3](v1.24.1-dev.2...v1.24.1-dev.3) (2025-04-10) ### Bug Fixes * Correct supported required patch option types ([#2475](#2475)) ([cde3f8d](cde3f8d))

Co-authored-by: Pun Butrach <[email protected]>

## [1.24.1-dev.4](v1.24.1-dev.3...v1.24.1-dev.4) (2025-04-13) ### Bug Fixes * Log errors and warnings when compiling resources ([5c7d52c](5c7d52c))

validcube

Interim review

When patch is unsupported, log now output TAG (PatchCompatibilityCheck) so that it will be easier to find/which file is responsible for the log.
Clean-up weird ahh spaces
Better proguard comment
Fix gradle directory

.github/workflows/release.yml

lib/utils/check_for_supported_patch.dart

android/app/proguard-rules.pro

validcube

Allow Flutter cache on PR (this shouldn't affect us much)

.github/workflows/build_pull_request.yml

Signed-off-by: Pun Butrach <[email protected]> Co-authored-by: Pun Butrach <[email protected]>

## [1.24.1-dev.5](v1.24.1-dev.4...v1.24.1-dev.5) (2025-04-17) ### Bug Fixes * Use device locale when no preference is set ([#2483](#2483)) ([f79aa9e](f79aa9e))

…ely deleting patched APK (#2490)

Co-authored-by: oSumAtrIX <[email protected]>

# [1.25.0-dev.1](v1.24.1-dev.5...v1.25.0-dev.1) (2025-05-05) ### Bug Fixes * Fix installation being cancelled at installation by not prematurely deleting patched APK ([#2490](#2490)) ([dedcb3c](dedcb3c)) * Use device locale for app language (Default to English) ([#2488](#2488)) ([3074766](3074766)) ### Features * Add toggle to use pre-releases ([#2485](#2485)) ([89b48ce](89b48ce))

lib/services/manager_api.dart

This is workaround to entirely disabling Flutter Impeller in favour of Skia. Signed-off-by: Pun Butrach <[email protected]>

Signed-off-by: Pun Butrach <[email protected]>

Based on https://github.com/github/gitignore/blob/main/Flutter.gitignore Signed-off-by: Pun Butrach <[email protected]>

Signed-off-by: Pun Butrach <[email protected]>

Signed-off-by: Pun Butrach <[email protected]> Co-authored-by: Crowdin Bot <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Pun Butrach <[email protected]>

Co-authored-by: Pun Butrach <[email protected]>

… on manager again (#2602) Signed-off-by: Pun Butrach <[email protected]>

# [1.25.0-dev.2](v1.25.0-dev.1...v1.25.0-dev.2) (2025-06-26) ### Bug Fixes * "Save patched app" attempts to copy APK when patching fails ([#2565](#2565)) ([bdb0317](bdb0317)) * Nearly all rare cases of GPU renderer issues, and allow building on manager again ([#2602](#2602)) ([21ceada](21ceada)) * Obscure Flutter Impeller renderer bugs ([a5e909c](a5e909c))

Copilot

Pull Request Overview

This PR merges the dev branch into main and includes a version bump and dependency updates in pubspec.yaml, new prerelease settings and related UI/viewmodel logic, adjustments to patch option handling, and extensive localization updates.

Updated version and dependency constraints in pubspec.yaml
New prerelease functionality added in settings view and viewmodel
Minor refactorings and logging improvements in various modules, plus multiple localization improvements

Reviewed Changes

Copilot reviewed 65 out of 68 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
pubspec.yaml	Version bump and updated dependency constraints.
lib/utils/check_for_supported_patch.dart	Adjusted supported patch option types and added debug logging.
lib/ui/widgets/settings_use_prereleases.dart	Introduced a new widget for enabling prerelease options.
lib/ui/widgets/patchesSelectorView/patch_options_fields.dart	Converted patch option value to a string explicitly.
lib/ui/views/settings/settings_viewmodel.dart	Added prereleases support methods and dialog for settings.
lib/ui/views/installer/installer_viewmodel.dart	Refactored runPatcher invocation and adjusted progress update values.
lib/ui/views/home/home_viewmodel.dart	Modified connectivity check formatting and navigation argument style.
lib/services/revanced_api.dart, manager_api.dart, github_api.dart	Updated API calls to include prerelease flags, and removed unused code.
assets/i18n/*	Multiple localization files updated with improved translations.

Comments suppressed due to low confidence (1)

lib/ui/widgets/patchesSelectorView/patch_options_fields.dart:88

[nitpick] Ensure that converting 'value' to a string using toString() does not inadvertently alter its intended behavior if 'value' is already a string; confirm that the conversion is intentional for handling non-string types.

                value: value.toString(),

Copilot · 2025-06-27T01:31:44Z

lib/utils/check_for_supported_patch.dart

@@ -38,6 +39,9 @@ bool hasUnsupportedRequiredOption(List<Option> options, Patch patch) {
  }
  for (final String optionType in requiredOptionsType) {
    if (!supportedOptionsType.contains(optionType)) {
+      if (kDebugMode) {
+        print('PatchCompatibilityCheck: ${patch.name} has unsupported required patch option type: $requiredOptionsType');


Consider logging the specific unsupported option type (i.e. 'optionType') rather than the entire list 'requiredOptionsType' to provide clearer debugging information.

Suggested change

print('PatchCompatibilityCheck: ${patch.name} has unsupported required patch option type: $requiredOptionsType');

print('PatchCompatibilityCheck: ${patch.name} has unsupported required patch option type: $optionType');

validcube · 2025-06-27T08:35:54Z

@Ushie Should I hold off this PR for Patcher v22 or release this now?

validcube · 2025-06-27T08:36:33Z

Pull Request Overview

This PR merges the dev branch into main and includes a version bump and dependency updates in pubspec.yaml, new prerelease settings and related UI/viewmodel logic, adjustments to patch option handling, and extensive localization updates.

Updated version and dependency constraints in pubspec.yaml

New prerelease functionality added in settings view and viewmodel

Minor refactorings and logging improvements in various modules, plus multiple localization improvements

Reviewed Changes

Copilot reviewed 65 out of 68 changed files in this pull request and generated 1 comment.

Show a summary per file

File Description

pubspec.yaml Version bump and updated dependency constraints.

lib/utils/check_for_supported_patch.dart Adjusted supported patch option types and added debug logging.

lib/ui/widgets/settings_use_prereleases.dart Introduced a new widget for enabling prerelease options.

lib/ui/widgets/patchesSelectorView/patch_options_fields.dart Converted patch option value to a string explicitly.

lib/ui/views/settings/settings_viewmodel.dart Added prereleases support methods and dialog for settings.

lib/ui/views/installer/installer_viewmodel.dart Refactored runPatcher invocation and adjusted progress update values.

lib/ui/views/home/home_viewmodel.dart Modified connectivity check formatting and navigation argument style.

lib/services/revanced_api.dart, manager_api.dart, github_api.dart Updated API calls to include prerelease flags, and removed unused code.

assets/i18n/* Multiple localization files updated with improved translations.
Comments suppressed due to low confidence (1)

lib/ui/widgets/patchesSelectorView/patch_options_fields.dart:88

[nitpick] Ensure that converting 'value' to a string using toString() does not inadvertently alter its intended behavior if 'value' is already a string; confirm that the conversion is intentional for handling non-string types.
                value: value.toString(),

Copilot low confidence nitpick is a very valid concern. Will check.

validcube and others added 4 commits April 4, 2025 22:59

fix: Crash using when Integer type in Patch Options (#2453)

05575cc

chore(release): 1.24.1-dev.1 [skip ci]

783f313

## [1.24.1-dev.1](v1.24.0...v1.24.1-dev.1) (2025-04-04) ### Bug Fixes * Crash using when Integer type in Patch Options ([#2453](#2453)) ([05575cc](05575cc))

fix: Unable to Share Logs due to missing ProGuard rules (#2474)

915ec0e

Technical commit message: fix: Unable to Share Logs due to CCE in FileProvider Signed-off-by: Pun Butrach <[email protected]>

chore(release): 1.24.1-dev.2 [skip ci]

221e663

## [1.24.1-dev.2](v1.24.1-dev.1...v1.24.1-dev.2) (2025-04-09) ### Bug Fixes * Unable to Share Logs due to missing ProGuard rules ([#2474](#2474)) ([915ec0e](915ec0e))

This was linked to issues Apr 9, 2025

bug: Version Code patch settings displays a gray block #2471

Closed

bug: Change Version Code has a bug displayed on ReVanced Manager #2037

Closed

bug: Unable to share log file #2418

Closed

bug: In Socials Menu #2443

Closed

validcube requested a review from Copilot April 10, 2025 14:11

Copilot AI reviewed Apr 10, 2025

View reviewed changes

validcube added 3 commits April 10, 2025 22:05

chore: Remove Android cxx generated file

7fa5daf

Signed-off-by: Pun Butrach <[email protected]>

chore: Default project Flutter devtools options configuration for deb…

8182228

…ugging

fix: Correct supported required patch option types (#2475)

cde3f8d

Signed-off-by: Pun Butrach <[email protected]>

validcube linked an issue Apr 10, 2025 that may be closed by this pull request

bug: Patch option unsupported when it is supported when trying to select patch #2321

Closed

4 tasks

semantic-release-bot and others added 6 commits April 10, 2025 15:26

chore(release): 1.24.1-dev.3 [skip ci]

a8a4ffa

## [1.24.1-dev.3](v1.24.1-dev.2...v1.24.1-dev.3) (2025-04-10) ### Bug Fixes * Correct supported required patch option types ([#2475](#2475)) ([cde3f8d](cde3f8d))

ci: Modernize workflows (#2473)

062f283

Co-authored-by: Pun Butrach <[email protected]>

ci: Point to Android directory

534e4c2

chore: Ignore Dart analysis on generated slang file

841d612

fix: Log errors and warnings when compiling resources

5c7d52c

chore(release): 1.24.1-dev.4 [skip ci]

10f35eb

## [1.24.1-dev.4](v1.24.1-dev.3...v1.24.1-dev.4) (2025-04-13) ### Bug Fixes * Log errors and warnings when compiling resources ([5c7d52c](5c7d52c))

validcube requested changes Apr 14, 2025

View reviewed changes

.github/workflows/release.yml Outdated Show resolved Hide resolved

lib/utils/check_for_supported_patch.dart Outdated Show resolved Hide resolved

lib/utils/check_for_supported_patch.dart Outdated Show resolved Hide resolved

android/app/proguard-rules.pro Outdated Show resolved Hide resolved

validcube added 3 commits April 14, 2025 15:51

ci: Use correct directory for Gradle cache

aedf475

chore: Remove x86 libaapt2.so binary (#2480)

b11a720

chore: Miscellaneous code clean-up

a1f9a27

validcube reviewed Apr 14, 2025

View reviewed changes

.github/workflows/build_pull_request.yml Show resolved Hide resolved

validcube and others added 4 commits April 14, 2025 17:20

ci: Flutter caching for build PR

ba758f3

build: Nuke script now able to remove empty JSON/File

007dce8

chore: Modify language assets to match Nuke

7ccc689

chore: Sync translations (#2384)

1c84265

Signed-off-by: Pun Butrach <[email protected]> Co-authored-by: Pun Butrach <[email protected]>

validcube requested a review from Copilot April 14, 2025 12:01

fix: Use device locale when no preference is set (#2483)

f79aa9e

This was linked to issues Apr 17, 2025

bug: Language is always set to English on launch #2478

Closed

feat: add languages in app, and make manager use android default language #243

Closed

System language #531

Closed

chore(release): 1.24.1-dev.5 [skip ci]

722f2b6

## [1.24.1-dev.5](v1.24.1-dev.4...v1.24.1-dev.5) (2025-04-17) ### Bug Fixes * Use device locale when no preference is set ([#2483](#2483)) ([f79aa9e](f79aa9e))

validcube requested a review from Copilot April 17, 2025 14:28

This comment was marked as outdated.

Sign in to view

TheAabedKhan and others added 5 commits May 5, 2025 15:54

fix: Use device locale for app language (Default to English) (#2488)

3074766

fix: Fix installation being cancelled at installation by not prematur…

dedcb3c

…ely deleting patched APK (#2490)

feat: Add toggle to use pre-releases (#2485)

89b48ce

Co-authored-by: oSumAtrIX <[email protected]>

ci: Run Crowdin Cron task on dev branch (#2543)

b046440

kitadai31 reviewed May 23, 2025

View reviewed changes

lib/services/manager_api.dart Outdated Show resolved Hide resolved

kitadai31 and others added 8 commits May 31, 2025 14:22

fix: "Save patched app" attempts to copy APK when patching fails (#2565)

bdb0317

fix: Obscure Flutter Impeller renderer bugs

a5e909c

This is workaround to entirely disabling Flutter Impeller in favour of Skia. Signed-off-by: Pun Butrach <[email protected]>

build: Support Flutter v3.32

d264a2a

Signed-off-by: Pun Butrach <[email protected]>

chore: Better ignore rules

1752fae

Based on https://github.com/github/gitignore/blob/main/Flutter.gitignore Signed-off-by: Pun Butrach <[email protected]>

ci: Set missing translation actor/email for commit

40c99ab

Signed-off-by: Pun Butrach <[email protected]>

chore: Sync translations (#2522)

7ee2b1a

Signed-off-by: Pun Butrach <[email protected]> Co-authored-by: Crowdin Bot <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Pun Butrach <[email protected]>

ci: Use install instead of clean install for NPM dependencies

8e4a908

Co-authored-by: Pun Butrach <[email protected]>

chore: Remove obsolete deleteLastPatchedApp call

83fc7f1

validcube linked an issue Jun 14, 2025 that may be closed by this pull request

bug: Empty patch options screen #2393

Closed

4 tasks

validcube and others added 2 commits June 26, 2025 12:40

fix: Nearly all rare cases of GPU renderer issues, and allow building…

21ceada

… on manager again (#2602) Signed-off-by: Pun Butrach <[email protected]>

validcube requested review from validcube and Copilot June 26, 2025 11:34

Copilot AI reviewed Jun 27, 2025

View reviewed changes

Ushie merged commit c45d579 into main Jun 27, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

chore: Merge branch `dev` to `main` #2468

chore: Merge branch `dev` to `main` #2468

Uh oh!

revanced-bot commented Apr 4, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

validcube left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

validcube left a comment

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jun 27, 2025

Uh oh!

validcube commented Jun 27, 2025

Uh oh!

validcube commented Jun 27, 2025

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

	print('PatchCompatibilityCheck: ${patch.name} has unsupported required patch option type: $requiredOptionsType');
	print('PatchCompatibilityCheck: ${patch.name} has unsupported required patch option type: $optionType');

Uh oh!

chore: Merge branch dev to main #2468

chore: Merge branch dev to main #2468

Uh oh!

Conversation

revanced-bot commented Apr 4, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

validcube left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

validcube left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Jun 27, 2025

Choose a reason for hiding this comment

Uh oh!

validcube commented Jun 27, 2025

Uh oh!

validcube commented Jun 27, 2025

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

chore: Merge branch `dev` to `main` #2468

chore: Merge branch `dev` to `main` #2468

validcube left a comment •

edited

Loading