Skip to content

fix: Close streams to be able to delete cache folder #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

fix: Close streams to be able to delete cache folder #70

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
38ff123
creating dex file stream on-demand instead of passing it around
May 15, 2025
2a34085
Wrap dex file stream with `use` block
May 27, 2025
d97e792
Apply suggestions from code review
oSumAtrIX May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/commonMain/kotlin/app/revanced/library/ApkUtils.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ object ApkUtils {
fun PatcherResult.applyTo(apkFile: File) {
ZFile.openReadWrite(apkFile, zFileOptions).use { targetApkZFile ->
dexFiles.forEach { dexFile ->
targetApkZFile.add(dexFile.name, dexFile.stream)
dexFile.stream.use { targetApkZFile.add(dexFile.name, it) }
}

resources?.let { resources ->
Expand Down