Player rendering parity & Coal Item

[Vimd0]

Did this on my phone, hope it works 😭

• Player scale and coal code taken from Tile Entity Logic #478
• Player shadow code taken from https://github.com/Wilyicaro/PEtoLE/blob/master/source/client/renderer/entity/EntityRenderer.cpp

[Wilyicaro]

did this on my phone, hope it works 😭

• Player scale and coal code taken from Tile Entity Logic #478
• Player shadow code taken from https://github.com/Wilyicaro/PEtoLE/blob/master/source/client/renderer/entity/EntityRenderer.cpp

Is the shadow rendering code working? Considering that I removed the height offset from the position

[Vimd0]

did this on my phone, hope it works 😭

• Player scale and coal code taken from Tile Entity Logic #478
• Player shadow code taken from https://github.com/Wilyicaro/PEtoLE/blob/master/source/client/renderer/entity/EntityRenderer.cpp

Is the shadow rendering code working? Considering that I removed the height offset from the position

It works

[BrentDaMage]

This is kind of a dumb bug to intentionally introduce imo.

[Vimd0]

You want it removed?

[BrentDaMage]

Yeah, don't intentionally re-add the bug.

[Vimd0]

Restored back the original

[Un1q32]

Broke the SDL2 submodule

[BrentDaMage]

Broke the SDL2 submodule

Maaaaan, fuck the SDL2 submodule.

[BrentDaMage]

Broke the SDL2 submodule

I just ran git submodule update and it looks like it changed nothing. Is there a problem? Are we not now just on latest?

[Un1q32]

It's already been changed you have to manually change it back, cd into the submodule directory and run git checkout cd6fbfbb035452a991b9762ecbb888b48ec84c1f, then commit the change

[BrentDaMage]

It's already been changed you have to manually change it back, cd into the submodule directory and run git checkout cd6fbfbb035452a991b9762ecbb888b48ec84c1f, then commit the change

Why do I need to change it back? Isn't our own fork the correct version of the code??

[Un1q32]

Our master branch has the right version. The PR made a commit to change the submodule version, now you have to make another commit to change it back to the correct version.

[BrentDaMage]

Our master branch has the right version. The PR made a commit to change the submodule version, now you have to make another commit to change it back to the correct version.

But I am running git submodule update. I am on the latest version of the submodule. Why is that problematic? Shouldn't the latest version of our SDL2 fork function correctly?

[Un1q32]

git submodule update doesn't update the submodule to the latest commit on a remote, the git repo is set to a specific commit and git submodule update just checks out that commit if your submodule is checked out to a different commit than the repo wants. Run the following:

cd thirdparty/SDL2/src
git checkout cd6fbfbb035452a991b9762ecbb888b48ec84c1f
cd ../../..
git add .
git commit -m "fix submodule"
git push