Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable lambdas in all sugar functions #1373

Merged
merged 7 commits into from
Mar 31, 2025
Merged

Conversation

Enchufa2
Copy link
Member

@Enchufa2 Enchufa2 commented Mar 29, 2025

Part of #1365, as discussed in #1370. Takes the idea in #296 that enabled lambdas for sapply, and generalizes it as a variadic result_of that now is applied to lapply, mapply and outer too, enabling lambdas for them too.

Checklist

  • Code compiles correctly
  • R CMD check still passes all tests
  • Preferably, new tests were added which fail without the change
  • Document the changes by file in ChangeLog

Copy link
Contributor

@kevinushey kevinushey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eddelbuettel
Copy link
Member

As discussed over DM as it happened, the reverse depends run for this one tossed up three packages coughing so to be refined or to be patched there.

@Enchufa2
Copy link
Member Author

Enchufa2 commented Mar 31, 2025

I think that 8ba2d7b fixes the issue (some, but not all). I dropped that before just because it was giving me problems, and collided somehow with the other specialization. But it works now, so my previous issues were probably due to some intermediate state of the PR.

@Enchufa2
Copy link
Member Author

Stupid mistake... I inadvertently dropped typedef at some point. Now expertsurv, flexsurv and texmex should compile just fine.

@eddelbuettel
Copy link
Member

Very nice, and confirmed for those three plus one that was flakey in the last run (and now passed too). Waiting on one new package....

eddelbuettel added a commit to RcppCore/rcpp-logs that referenced this pull request Mar 31, 2025
Copy link
Member

@eddelbuettel eddelbuettel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thumbs up!

@Enchufa2 Enchufa2 merged commit a1737c1 into master Mar 31, 2025
20 checks passed
@Enchufa2 Enchufa2 deleted the feature/result_of_function branch March 31, 2025 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants