-
-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove macros for unordered maps/sets #1372
Conversation
020c2cd
to
dca5edb
Compare
Rebased. |
Used by #1372
Rev dep now running with tag 1.0.14.11. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice and clean, should not do damage but let's wait just in case.
(And let's keep in mind that I also skip a few of the more expensive ones...)
BTW I think you accidentally mistyped the buttons in the checklist. Hit number two but skip number three? |
I did! Fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
As anticipated, this too passed without event or issues, more here, so merging. |
Pretty simple one. Will rebase and mark as ready for review when #1371 is merged.
Checklist
R CMD check
still passes all tests