Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove macros for unordered maps/sets #1372

Merged
merged 4 commits into from
Mar 28, 2025
Merged

Conversation

Enchufa2
Copy link
Member

@Enchufa2 Enchufa2 commented Mar 24, 2025

Pretty simple one. Will rebase and mark as ready for review when #1371 is merged.

Checklist

  • Code compiles correctly
  • R CMD check still passes all tests
  • Preferably, new tests were added which fail without the change
  • Document the changes by file in ChangeLog

@Enchufa2 Enchufa2 force-pushed the feature/unordered branch from 020c2cd to dca5edb Compare March 26, 2025 19:27
@Enchufa2 Enchufa2 marked this pull request as ready for review March 26, 2025 19:27
@Enchufa2
Copy link
Member Author

Rebased.

@eddelbuettel
Copy link
Member

Rev dep now running with tag 1.0.14.11.

Copy link
Member

@eddelbuettel eddelbuettel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean, should not do damage but let's wait just in case.

(And let's keep in mind that I also skip a few of the more expensive ones...)

@eddelbuettel
Copy link
Member

BTW I think you accidentally mistyped the buttons in the checklist. Hit number two but skip number three?

@Enchufa2
Copy link
Member Author

I did! Fixed.

Copy link
Contributor

@kevinushey kevinushey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

eddelbuettel added a commit to RcppCore/rcpp-logs that referenced this pull request Mar 28, 2025
@eddelbuettel
Copy link
Member

As anticipated, this too passed without event or issues, more here, so merging.

@eddelbuettel eddelbuettel merged commit 30df687 into master Mar 28, 2025
20 checks passed
@eddelbuettel eddelbuettel deleted the feature/unordered branch March 28, 2025 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants