Skip to content

Fix MCP cleanup trap scoping issue causing exit errors #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fletchgqc wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix MCP cleanup trap scoping issue causing exit errors #73

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions lib/docker.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,17 +296,11 @@ run_claudebox_container() {
# Set up cleanup trap for temporary MCP config files
cleanup_mcp_files() {
local file
for file in "${mcp_temp_files[@]}"; do
for file in "${mcp_temp_files[@]:-}"; do
if [[ -f "$file" ]]; then
rm -f "$file"
fi
done
if [[ -n "$user_mcp_file" ]] && [[ -f "$user_mcp_file" ]]; then
rm -f "$user_mcp_file"
fi
if [[ -n "$project_mcp_file" ]] && [[ -f "$project_mcp_file" ]]; then
rm -f "$project_mcp_file"
fi
}
trap cleanup_mcp_files EXIT

Expand All @@ -315,6 +309,7 @@ run_claudebox_container() {
user_mcp_file=$(create_mcp_config_file "$HOME/.claude.json" "")

if [[ -n "$user_mcp_file" ]]; then
mcp_temp_files+=("$user_mcp_file")
local user_count=$(jq '.mcpServers | length' "$user_mcp_file" 2>/dev/null || echo "0")
if [[ "$user_count" -gt 0 ]]; then
if [[ "$VERBOSE" == "true" ]]; then
Expand Down Expand Up @@ -358,6 +353,7 @@ run_claudebox_container() {
local project_count=$(jq '.mcpServers | length' "$temp_project_file" 2>/dev/null || echo "0")
if [[ "$project_count" -gt 0 ]]; then
project_mcp_file="$temp_project_file"
# Note: temp_project_file already added to mcp_temp_files above
if [[ "$VERBOSE" == "true" ]]; then
printf "Found %s project MCP servers\n" "$project_count" >&2
fi
Expand Down
Loading