Skip to content

feat: Pass environment variables from .env file to container#70

Open
fletchgqc wants to merge 1 commit into
RchGrav:mainfrom
fletchgqc:env-file-support
Open

feat: Pass environment variables from .env file to container#70
fletchgqc wants to merge 1 commit into
RchGrav:mainfrom
fletchgqc:env-file-support

Conversation

@fletchgqc
Copy link
Copy Markdown
Contributor

@fletchgqc fletchgqc commented Sep 9, 2025

Add --env-file option to docker run command when .env file exists in the project directory. This allows environment variables defined in .env to be automatically available inside the container.

The .env file was already being mounted, but variables weren't being loaded. This simple change adds the --env-file flag to make Docker parse and load all variables from the file.

Summary by Sourcery

New Features:

  • Pass environment variables from .env into the Docker container using the --env-file flag

Add --env-file option to docker run command when .env file exists
in the project directory. This allows environment variables defined
in .env to be automatically available inside the container.

The .env file was already being mounted, but variables weren't being
loaded. This simple change adds the --env-file flag to make Docker
parse and load all variables from the file.
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Sep 9, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Enhance run_claudebox_container in lib/docker.sh to automatically load environment variables from a .env file by adding the --env-file flag to the docker run command and updating the verbose debug output accordingly.

File-Level Changes

Change Details Files
Automatically load environment variables from .env into the container
  • Append --env-file "$PROJECT_DIR/.env" to docker_args when .env exists
lib/docker.sh
Update debug logging to reflect loading of .env variables
  • Change verbose echo from "[DEBUG] Mounting .env file" to "[DEBUG] Mounting and loading .env file"
lib/docker.sh

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

fogXploit added a commit to fogXploit/claudebox2.0 that referenced this pull request Oct 24, 2025
Updated documentation to reflect:
- Implementation of PR RchGrav#78 (array expansion safety for macOS)
- Implementation of PR RchGrav#73 (MCP cleanup trap scoping fix)
- Status of all 11 open PRs from original repository
- Prioritization and recommendations for remaining PRs
- Next steps: PR RchGrav#70, RchGrav#67, RchGrav#74 ready to implement

This ensures the next Claude instance has complete context about:
- What's been done
- What's still to do
- Which PRs to skip/defer
- Current test results (71/71 passing)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant