Skip to content

support 3rd party vendor and fix local can only used in function warning#103

Closed
shen390s wants to merge 1 commit into
RchGrav:mainfrom
shen390s:vendors
Closed

support 3rd party vendor and fix local can only used in function warning#103
shen390s wants to merge 1 commit into
RchGrav:mainfrom
shen390s:vendors

Conversation

@shen390s
Copy link
Copy Markdown

@shen390s shen390s commented Mar 20, 2026

  • Add support 3rd party vendor, by set ANTHROPIC_BASE_URL and ANTHROPIC_AUTH_TOKEN in environment
  • Fix shell warning, local keyword just can used in function in file build/docker-entrypoint line 106

Rongsong

Summary by Sourcery

Add environment configuration for Anthropic third-party vendor support in the Claudebox Docker container and adjust exported shell functions in the Docker helper script.

New Features:

  • Pass ANTHROPIC_BASE_URL and ANTHROPIC_AUTH_TOKEN environment variables into the Claudebox Docker container to support third-party Anthropic-compatible vendors.

Enhancements:

  • Refine the list of exported shell functions in lib/docker.sh to align with current usage.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Mar 20, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates the Docker tooling to pass through optional Anthropic vendor configuration into the Claudebox container and fixes a shell warning by adjusting how shell-local declarations are used in the docker entrypoint script.

File-Level Changes

Change Details Files
Pass Anthropic 3rd‑party vendor configuration into the Claudebox Docker container as environment variables.
  • Extend run_claudebox_container docker_args array to include ANTHROPIC_BASE_URL with a default of empty string
  • Extend run_claudebox_container docker_args array to include ANTHROPIC_AUTH_TOKEN with a default of empty string
lib/docker.sh
Fix shell "local" usage warning in Docker entrypoint script.
  • Adjust variable declaration or placement around line 106 to ensure local is only used inside shell functions (exact change not visible in provided diff)
build/docker-entrypoint

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • When propagating ANTHROPIC_BASE_URL and ANTHROPIC_AUTH_TOKEN into docker_args, consider only adding the -e entries when the variables are actually set to avoid explicitly overriding any image defaults with empty values.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- When propagating ANTHROPIC_BASE_URL and ANTHROPIC_AUTH_TOKEN into docker_args, consider only adding the -e entries when the variables are actually set to avoid explicitly overriding any image defaults with empty values.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@shen390s shen390s closed this by deleting the head repository May 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant