support 3rd party vendor and fix local can only used in function warning#103
Closed
shen390s wants to merge 1 commit into
Closed
support 3rd party vendor and fix local can only used in function warning#103shen390s wants to merge 1 commit into
shen390s wants to merge 1 commit into
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR updates the Docker tooling to pass through optional Anthropic vendor configuration into the Claudebox container and fixes a shell warning by adjusting how shell-local declarations are used in the docker entrypoint script. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- When propagating ANTHROPIC_BASE_URL and ANTHROPIC_AUTH_TOKEN into docker_args, consider only adding the -e entries when the variables are actually set to avoid explicitly overriding any image defaults with empty values.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- When propagating ANTHROPIC_BASE_URL and ANTHROPIC_AUTH_TOKEN into docker_args, consider only adding the -e entries when the variables are actually set to avoid explicitly overriding any image defaults with empty values.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rongsong
Summary by Sourcery
Add environment configuration for Anthropic third-party vendor support in the Claudebox Docker container and adjust exported shell functions in the Docker helper script.
New Features:
Enhancements: