fix: remove local used outside functions in docker-entrypoint#100
Open
b00y0h wants to merge 1 commit into
Open
fix: remove local used outside functions in docker-entrypoint#100b00y0h wants to merge 1 commit into
local used outside functions in docker-entrypoint#100b00y0h wants to merge 1 commit into
Conversation
|
🧙 Sourcery has finished reviewing your pull request! Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
The docker-entrypoint script uses `local` at lines 86, 109, and 141, but these are at the top-level scope (not inside any function). With `set -euo pipefail` enabled, bash exits immediately with: local: can only be used in a function Replace with plain variable assignments since these variables don't need function-scoped locality. Fixes RchGrav#65
0ed3374 to
80a1cfc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove three
localkeyword usages at top-level scope inbuild/docker-entrypoint(lines 86, 109, 141) that cause the container to fail on startup.Problem
The entrypoint script has
set -euo pipefailand useslocaloutside of any function. Bash rejects this:This causes the container to exit immediately after a successful build, making ClaudeBox unusable once profiles that trigger Python venv setup are enabled.
Fix
Replace
localwith plain variable assignments. These variables (wait_count,python_packages) are already deeply nested in conditionals and don't need function-scoped locality.Fixes #65
Summary by Sourcery
Bug Fixes:
localkeyword at top-level scope in the docker entrypoint script that caused startup failures.