Skip to content

fix: remove local used outside functions in docker-entrypoint#100

Open
b00y0h wants to merge 1 commit into
RchGrav:mainfrom
b00y0h:fix/entrypoint-local-outside-function
Open

fix: remove local used outside functions in docker-entrypoint#100
b00y0h wants to merge 1 commit into
RchGrav:mainfrom
b00y0h:fix/entrypoint-local-outside-function

Conversation

@b00y0h
Copy link
Copy Markdown

@b00y0h b00y0h commented Feb 12, 2026

Summary

Remove three local keyword usages at top-level scope in build/docker-entrypoint (lines 86, 109, 141) that cause the container to fail on startup.

Problem

The entrypoint script has set -euo pipefail and uses local outside of any function. Bash rejects this:

/usr/local/bin/docker-entrypoint: line 141: local: can only be used in a function

This causes the container to exit immediately after a successful build, making ClaudeBox unusable once profiles that trigger Python venv setup are enabled.

Fix

Replace local with plain variable assignments. These variables (wait_count, python_packages) are already deeply nested in conditionals and don't need function-scoped locality.

Fixes #65

Summary by Sourcery

Bug Fixes:

  • Remove invalid uses of the bash local keyword at top-level scope in the docker entrypoint script that caused startup failures.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Feb 12, 2026

🧙 Sourcery has finished reviewing your pull request!


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

The docker-entrypoint script uses `local` at lines 86, 109, and 141,
but these are at the top-level scope (not inside any function). With
`set -euo pipefail` enabled, bash exits immediately with:

  local: can only be used in a function

Replace with plain variable assignments since these variables don't
need function-scoped locality.

Fixes RchGrav#65
@b00y0h b00y0h force-pushed the fix/entrypoint-local-outside-function branch from 0ed3374 to 80a1cfc Compare February 12, 2026 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ClaudeBox only started once, then fails

1 participant