Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force strip = false and cleanup env handling #106

Merged
merged 3 commits into from
May 9, 2024
Merged

Force strip = false and cleanup env handling #106

merged 3 commits into from
May 9, 2024

Conversation

intelfx
Copy link
Contributor

@intelfx intelfx commented May 7, 2024 •
edited
Loading

This does two things:

  • cleans up env override handling to force debug = true (on MSVC) for the current profile rather than "release"
  • adds another env override to set strip = false for the current profile

Fixes #87.

@intelfx intelfx force-pushed the work/force-unstripped branch from f88d302 to f5f2048 Compare May 7, 2024 23:28
RazrFalcon
RazrFalcon reviewed May 8, 2024
View reviewed changes
src/main.rs Outdated Show resolved Hide resolved
RazrFalcon
RazrFalcon reviewed May 8, 2024
View reviewed changes
src/main.rs Outdated Show resolved Hide resolved
RazrFalcon
RazrFalcon reviewed May 8, 2024
View reviewed changes
src/main.rs Outdated Show resolved Hide resolved
@RazrFalcon
Copy link
Owner

Thanks. Hopefully it would be enough.

@intelfx intelfx force-pushed the work/force-unstripped branch from f5f2048 to 6ce66f6 Compare May 8, 2024 16:51
@RazrFalcon RazrFalcon merged commit 122e1cd into RazrFalcon:master May 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RazrFalcon RazrFalcon RazrFalcon left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Detect strip = true in Cargo.toml
2 participants
@intelfx @RazrFalcon